[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [lintian] 02/02: Remove "." from @INC



Jakub Wilk:
> This is an automated email from the git hooks/post-receive script.
> 
> jwilk pushed a commit to branch master
> in repository lintian.
> 
> commit c92ba9515d581077e37dc4421272ef32516a403f
> Author: Jakub Wilk <jwilk@debian.org>
> Date:   Thu Jun 30 22:29:00 2016 +0200
> 
>     Remove "." from @INC
>     
> [...]

Hi,

Thanks for this.

> ---
>  collection/ar-info                 | 1 +
>  [...]
>  collection/unpacked                | 1 +

I was expecting to see "commands/lintian" here as well, as it is (the
only command that is) exec'ed rather than "perl required" by dplint.

>  debian/changelog                   | 9 +++++++++
>  [...]
> diff --git a/collection/ar-info b/collection/ar-info
> index 7ee33e7..4bc679f 100755
> --- a/collection/ar-info
> +++ b/collection/ar-info
> @@ -24,6 +24,7 @@ package Lintian::coll::ar_info;
>  use strict;
>  use warnings;
>  use autodie;
> +no lib '.';

Shouldn't these come before the first "use"?  Rather, can we even
protect ourselves by using "no lib" - doesn't that load "lib" with the
current @INC path?

>  [...]

Thanks,
~Niels




Reply to: