[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/02: c/v-s: Add tag to tally possible arch:all binNMU problems



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit f530c102f13657bbe5f092c0df17fdbe5202966d
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Mar 13 20:27:10 2016 +0000

    c/v-s: Add tag to tally possible arch:all binNMU problems
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 checks/version-substvars.desc                              | 11 +++++++++++
 checks/version-substvars.pm                                |  8 ++++++--
 debian/changelog                                           |  8 ++++++++
 t/tests/version-substvars-general/debian/debian/control.in |  3 ++-
 t/tests/version-substvars-general/desc                     |  1 +
 t/tests/version-substvars-general/tags                     |  1 +
 6 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/checks/version-substvars.desc b/checks/version-substvars.desc
index ab4eb7f..a23e481 100644
--- a/checks/version-substvars.desc
+++ b/checks/version-substvars.desc
@@ -61,3 +61,14 @@ Info: The package uses the now deprecated ${Source-Version} substvar,
  ${source:Version} as appropriate (introduced in dpkg 1.13.19, released
  with etch).  Support for ${Source-Version} may be removed from dpkg-dev
  in the future.
+
+Tag: maybe-not-arch-all-binnmuable
+Severity: wishlist
+certainty: possible
+Experimental: yes
+Info: Tag to attempt to measure the number of packages that might
+ have an issue with arch:all binNMUs.
+ .
+ At this time, please do <i>not</i> attempt to "fix" the problem.  It
+ is not clear what the solution is (if any at all).  Nor is it clear
+ that this is something that will be supported.
diff --git a/checks/version-substvars.pm b/checks/version-substvars.pm
index 124b354..bb8395c 100644
--- a/checks/version-substvars.pm
+++ b/checks/version-substvars.pm
@@ -120,10 +120,14 @@ sub run {
                         # a bit weird.
                         1;
                     }
-                } elsif (not $pkg2_is_any and not $substvar_strips_binNMU) {
+                } elsif (not $pkg2_is_any) {
                     # (b2) any -> all ( = ${binary:Version}) [or S-V]
                     # or  -- same --  (>= ${binary:Version}) [or S-V]
-                    tag 'not-binnmuable-any-depends-all', "$pkg1 -> $pkg2";
+                    tag 'not-binnmuable-any-depends-all', "$pkg1 -> $pkg2"
+                      if not $substvar_strips_binNMU;
+                    if ($substvar_strips_binNMU and not $gt) {
+                        tag 'maybe-not-arch-all-binnmuable', "$pkg1 -> $pkg2";
+                    }
                 }
             } elsif ($pkg2_is_any && !$gt) {
                 # (b3) all -> any (= ${either-of-them})
diff --git a/debian/changelog b/debian/changelog
index 7752690..f0bd68f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,14 @@ lintian (2.5.43) UNRELEASED; urgency=medium
 
   XXX: generate tag summary with private/generate-tag-summary
 
+  * checks/version-substvars.{desc,pm}:
+    + [NT] Add an experimental tag to check for arch:all
+      binNMUability.  This is currently not supported at all
+      and there is no known fix for the tag.  That said, it
+      is still useful for determine how many packages might
+      be affected by it in case Debian will support arch:all
+      binNMUs.
+
   * commands/reporting-sync-state.pm:
     + [NT] Use the sha256 instead of the sha1 checksum field
       for finding related files and checking of members have
diff --git a/t/tests/version-substvars-general/debian/debian/control.in b/t/tests/version-substvars-general/debian/debian/control.in
index 32c2db6..d38798a 100644
--- a/t/tests/version-substvars-general/debian/debian/control.in
+++ b/t/tests/version-substvars-general/debian/debian/control.in
@@ -8,7 +8,8 @@ Build-Depends: debhelper (>= 9)
 Package: program-bin
 Architecture: any
 Depends: $\{shlibs:Depends\}, $\{misc:Depends\},
-         program-data (= $\{binary:Version\})
+         program-data (= $\{binary:Version\}),
+         program-data-extra (= $\{source:Version\})
 Description: {$description}
  This is a test package designed to exercise some feature or tag of
  Lintian.  It is part of the Lintian test suite and may do very odd
diff --git a/t/tests/version-substvars-general/desc b/t/tests/version-substvars-general/desc
index 7629b01..f89fc40 100644
--- a/t/tests/version-substvars-general/desc
+++ b/t/tests/version-substvars-general/desc
@@ -3,6 +3,7 @@ Sequence: 6000
 Version: 1.0
 Description: Test of substvars
 Test-For:
+ maybe-not-arch-all-binnmuable
  not-binnmuable-all-depends-any
  not-binnmuable-any-depends-all
  not-binnmuable-any-depends-any
diff --git a/t/tests/version-substvars-general/tags b/t/tests/version-substvars-general/tags
index d1a6efa..4091c66 100644
--- a/t/tests/version-substvars-general/tags
+++ b/t/tests/version-substvars-general/tags
@@ -5,3 +5,4 @@ E: version-substvars-general source: not-binnmuable-any-depends-any program-util
 E: version-substvars-general source: version-substvar-for-external-package program-data -> foreign-pkg
 E: version-substvars-general source: version-substvar-for-external-package program-data -> other-foreign-pkg
 W: version-substvars-general source: substvar-source-version-is-deprecated program-data
+X: version-substvars-general source: maybe-not-arch-all-binnmuable program-bin -> program-data-extra

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: