[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#817068: Wildcard in overrides no longer appears to work mid-string



Control: tags -1 moreinfo

Thomas Friedrichsmeier:
> Package: lintian
> Version: 2.5.42
> 
> Trying to overrides some source-is-missing false-positives in package
> rkward, I note that wildcard matching no longer appears to work at
> start or mid of string. I'm trying to override source is missing for
> 
>   E: rkward source: source-is-missing rkward/plugins/plots/box_plot.js
>   line length is 257 characters (>256)
>   E: rkward source: source-is-missing
>   rkward/plugins/analysis/power/Poweranalysis.js line length is 538
>   characters (>512)
> 
> [...]
> 
> I would expect the following three override variants to all do the
> trick, but only variant 3 overrides, successfully:
> 
> 1)
> rkward source: source-is-missing *.js
> 2)
> rkward source: source-is-missing rkward/plugins/*.js
> 3)
> rkward source: source-is-missing rkward/plugins/*
> 
> Variant 2 used to work with some earlier version of lintian, current
> around December 2015. I never used Variant 1 except for testing.
> 
> Regards
> Thomas
> 

Hi Thomas,

From my PoV, it seems to work as designed and the override is wrong.

To take your first example:

  rkward/plugins/plots/box_plot.js line length is 257 characters (>256)
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                          MUST ALSO BE MATCHED!

AFAICT, neither of your 2 first overrides matches that and nor should
they since:

 1) "*.js" fails to match "line length is 257 characters (>256)"

 2) "rkward/plugins/*.js" - same as 1)

An alternative override that should work:

 source-is-missing *.js line length is * characters (>256)

Thanks,
~Niels



Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: