[lintian] 02/02: Style-only change: Remove unncessary ->
This is an automated email from the git hooks/post-receive script.
nthykier pushed a commit to branch master
in repository lintian.
commit 42b9a5290124201bb6067d3c12a5b13c5a461115
Author: Niels Thykier <niels@thykier.net>
Date: Sat Feb 6 10:32:44 2016 +0000
Style-only change: Remove unncessary ->
In short, rewrite the following:
"a->{b}->{c}" into "a->{b}{c}"
"a->[b]->{c}" into "a->[b]{c}"
"a->{b}->[c]" into "a->{b}[c]"
"a->[b]->[c]" into "a->[b][c]"
Signed-off-by: Niels Thykier <niels@thykier.net>
---
checks/binaries.pm | 2 +-
checks/fields.pm | 44 +++++++++++-----------
checks/group-checks.pm | 12 +++---
checks/java.pm | 8 ++--
checks/scripts.pm | 4 +-
checks/shared-libs.pm | 12 +++---
checks/testsuite.pm | 2 +-
lib/Lintian/Architecture.pm | 8 ++--
lib/Lintian/CheckScript.pm | 8 ++--
lib/Lintian/CollScript.pm | 16 ++++----
lib/Lintian/Collect/Binary.pm | 24 ++++++------
lib/Lintian/Collect/Changes.pm | 2 +-
lib/Lintian/Collect/Package.pm | 6 +--
lib/Lintian/Collect/Source.pm | 12 +++---
lib/Lintian/DepMap.pm | 30 +++++++--------
lib/Lintian/DepMap/Properties.pm | 6 +--
lib/Lintian/Lab/Entry.pm | 8 ++--
lib/Lintian/Lab/Manifest.pm | 4 +-
lib/Lintian/Path.pm | 10 ++---
lib/Lintian/Processable.pm | 6 +--
lib/Lintian/ProcessablePool.pm | 10 ++---
lib/Lintian/Profile.pm | 62 +++++++++++++++----------------
lib/Lintian/Relation.pm | 6 +--
lib/Lintian/Unpacker.pm | 8 ++--
private/graph | 8 ++--
private/refresh-archs | 30 +++++++--------
reporting/html_reports | 2 +-
t/scripts/Lintian/Lab/Manifest/01-basic.t | 2 +-
28 files changed, 176 insertions(+), 176 deletions(-)
diff --git a/checks/binaries.pm b/checks/binaries.pm
index 123c181..88537f8 100644
--- a/checks/binaries.pm
+++ b/checks/binaries.pm
@@ -650,7 +650,7 @@ sub run {
sub tag_unneeded_sections {
my ($tag, $file, $objdump) = @_;
foreach my $sect ('.note', '.comment') {
- if (exists $objdump->{'SH'}->{$sect}) {
+ if (exists $objdump->{'SH'}{$sect}) {
tag $tag, "$file $sect";
}
}
diff --git a/checks/fields.pm b/checks/fields.pm
index c6849b3..f29f4b2 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -693,37 +693,37 @@ sub run {
for (split /\s*\|\s*/, $dep);
if (&$is_dep_field($field)) {
- push @seen_libstdcs, $alternatives[0]->[0]
- if defined $known_libstdcs{$alternatives[0]->[0]};
- push @seen_tcls, $alternatives[0]->[0]
- if defined $known_tcls{$alternatives[0]->[0]};
- push @seen_tclxs, $alternatives[0]->[0]
- if defined $known_tclxs{$alternatives[0]->[0]};
- push @seen_tks, $alternatives[0]->[0]
- if defined $known_tks{$alternatives[0]->[0]};
- push @seen_tkxs, $alternatives[0]->[0]
- if defined $known_tkxs{$alternatives[0]->[0]};
- push @seen_libpngs, $alternatives[0]->[0]
- if defined $known_libpngs{$alternatives[0]->[0]};
+ push @seen_libstdcs, $alternatives[0][0]
+ if defined $known_libstdcs{$alternatives[0][0]};
+ push @seen_tcls, $alternatives[0][0]
+ if defined $known_tcls{$alternatives[0][0]};
+ push @seen_tclxs, $alternatives[0][0]
+ if defined $known_tclxs{$alternatives[0][0]};
+ push @seen_tks, $alternatives[0][0]
+ if defined $known_tks{$alternatives[0][0]};
+ push @seen_tkxs, $alternatives[0][0]
+ if defined $known_tkxs{$alternatives[0][0]};
+ push @seen_libpngs, $alternatives[0][0]
+ if defined $known_libpngs{$alternatives[0][0]};
}
# Only for (Pre-)?Depends.
tag 'virtual-package-depends-without-real-package-depends',
- "$field: $alternatives[0]->[0]"
+ "$field: $alternatives[0][0]"
if (
- $VIRTUAL_PACKAGES->known($alternatives[0]->[0])
+ $VIRTUAL_PACKAGES->known($alternatives[0][0])
&& ($field eq 'depends' || $field eq 'pre-depends')
- && ($pkg ne 'base-files' || $alternatives[0]->[0] ne 'awk')
+ && ($pkg ne 'base-files' || $alternatives[0][0] ne 'awk')
# ignore phpapi- dependencies as adding an
# alternative, real, package breaks its purpose
- && $alternatives[0]->[0] !~ m/^phpapi-/
+ && $alternatives[0][0] !~ m/^phpapi-/
);
# Check defaults for transitions. Here, we only care
# that the first alternative is current.
- tag 'depends-on-old-emacs', "$field: $alternatives[0]->[0]"
+ tag 'depends-on-old-emacs', "$field: $alternatives[0][0]"
if ( &$is_dep_field($field)
- && $known_obsolete_emacs{$alternatives[0]->[0]});
+ && $known_obsolete_emacs{$alternatives[0][0]});
for my $part_d (@alternatives) {
my ($d_pkg, undef, $d_version, undef, undef, $rest,
@@ -876,7 +876,7 @@ sub run {
// '';
$replacement = ' => ' . $replacement
if $replacement ne '';
- if ($pkg_name eq $alternatives[0]->[0]
+ if ($pkg_name eq $alternatives[0][0]
or scalar @seen_obsolete_packages
== scalar @alternatives) {
tag 'depends-on-obsolete-package',
@@ -968,8 +968,8 @@ sub run {
for (split /\s*\|\s*/, $dep);
tag 'virtual-package-depends-without-real-package-depends',
- "$field: $alternatives[0]->[0]"
- if ( $VIRTUAL_PACKAGES->known($alternatives[0]->[0])
+ "$field: $alternatives[0][0]"
+ if ( $VIRTUAL_PACKAGES->known($alternatives[0][0])
&& &$is_dep_field($field));
for my $part_d (@alternatives) {
@@ -1092,7 +1092,7 @@ sub run {
// '';
$replacement = ' => ' . $replacement
if $replacement ne '';
- if ( $pkg_name eq $alternatives[0]->[0]
+ if ( $pkg_name eq $alternatives[0][0]
or $all_obsolete) {
tag 'build-depends-on-obsolete-package',
"$field: $dep${replacement}";
diff --git a/checks/group-checks.pm b/checks/group-checks.pm
index a3bed60..b37e499 100644
--- a/checks/group-checks.pm
+++ b/checks/group-checks.pm
@@ -204,13 +204,13 @@ sub tarjans {
$self->{stack} = [];
$self->{on_stack} = {};
# The information for each node:
- # $self->{node_info}->{$node}->[X], where X is:
+ # $self->{node_info}{$node}[X], where X is:
# 0 => index
# 1 => low_index
$self->{node_info} = {};
foreach my $node (@$nodes) {
$self->_tarjans_sc($node)
- unless defined $self->{node_info}->{$node};
+ unless defined $self->{node_info}{$node};
}
return $self->{scc};
}
@@ -221,20 +221,20 @@ sub _tarjans_sc {
my $stack = $self->{stack};
my $ninfo = [$index, $index];
my $on_stack = $self->{on_stack};
- $self->{node_info}->{$node} = $ninfo;
+ $self->{node_info}{$node} = $ninfo;
$index++;
$self->{index} = $index;
push @$stack, $node;
$on_stack->{$node} = 1;
- foreach my $neighbour (@{ $self->{edges}->{$node} }){
+ foreach my $neighbour (@{ $self->{edges}{$node} }){
my $nb_info;
- $nb_info = $self->{node_info}->{$neighbour};
+ $nb_info = $self->{node_info}{$neighbour};
if (!defined $nb_info){
# First time visit
$self->_tarjans_sc($neighbour);
# refresh $nb_info
- $nb_info = $self->{node_info}->{$neighbour};
+ $nb_info = $self->{node_info}{$neighbour};
# min($node.low_index, $neigh.low_index)
$ninfo->[1] = $nb_info->[1] if $nb_info->[1] < $ninfo->[1];
} elsif (exists $on_stack->{$neighbour}) {
diff --git a/checks/java.pm b/checks/java.pm
index f4b7348..a9507b6 100644
--- a/checks/java.pm
+++ b/checks/java.pm
@@ -52,8 +52,8 @@ sub run {
# We first loop over jar files to find problems
for my $jar_file (sort keys %{$java_info}) {
- my $files = $java_info->{$jar_file}->{files};
- my $manifest = $java_info->{$jar_file}->{manifest};
+ my $files = $java_info->{$jar_file}{files};
+ my $manifest = $java_info->{$jar_file}{manifest};
my $operm = $info->index($jar_file)->operm;
my $jar_dir;
my $classes = 0;
@@ -61,9 +61,9 @@ sub run {
my $cp = '';
my $bsname = '';
- if (exists $java_info->{$jar_file}->{error}) {
+ if (exists $java_info->{$jar_file}{error}) {
tag 'zip-parse-error', "$jar_file:",
- $java_info->{$jar_file}->{error};
+ $java_info->{$jar_file}{error};
next;
}
diff --git a/checks/scripts.pm b/checks/scripts.pm
index 356e41e..246719c 100644
--- a/checks/scripts.pm
+++ b/checks/scripts.pm
@@ -248,8 +248,8 @@ sub run {
my $str_deps = $info->relation('strong');
for my $filename (sort keys %{$info->scripts}) {
- my $interpreter = $info->scripts->{$filename}->{interpreter};
- my $calls_env = $info->scripts->{$filename}->{calls_env};
+ my $interpreter = $info->scripts->{$filename}{interpreter};
+ my $calls_env = $info->scripts->{$filename}{calls_env};
my $path;
$scripts{$filename} = 1;
diff --git a/checks/shared-libs.pm b/checks/shared-libs.pm
index 1e02ff8..c165321 100644
--- a/checks/shared-libs.pm
+++ b/checks/shared-libs.pm
@@ -127,19 +127,19 @@ sub run {
# Now that we're sure this is really a shared library, report on
# non-PIC problems.
- if ($objdump->{$cur_file}->{TEXTREL}) {
+ if ($objdump->{$cur_file}{TEXTREL}) {
tag 'shlib-with-non-pic-code', $cur_file;
}
my @symbol_names
- = map { @{$_}[2] } @{$objdump->{$cur_file}->{SYMBOLS}};
+ = map { @{$_}[2] } @{$objdump->{$cur_file}{SYMBOLS}};
if ( (any { m/^_?exit$/ } @symbol_names)
&& (none { $_ eq 'fork' } @symbol_names)) {
# If it has an INTERP section it might be an application with
# a SONAME (hi openjdk-6, see #614305). Also see the comment
# for "shlib-with-executable-bit" below.
tag 'shlib-calls-exit', $cur_file
- unless $objdump->{$cur_file}->{INTERP};
+ unless $objdump->{$cur_file}{INTERP};
}
# executable?
@@ -150,7 +150,7 @@ sub run {
# report an error. Also give ld.so a pass, since it's
# special.
tag 'shlib-with-executable-bit', $cur_file, $perms
- unless ($objdump->{$cur_file}->{INTERP}
+ unless ($objdump->{$cur_file}{INTERP}
or $cur_file =~ m,^lib(?:32|64)?/ld-[\d.]+\.so$,);
} elsif ($perm != 0644) {
tag 'shlib-with-bad-permissions', $cur_file, $perms;
@@ -160,13 +160,13 @@ sub run {
# section on some architectures. Only warn if there's an
# Architecture field; if that's missing, we'll already be
# complaining elsewhere.
- if (not defined $objdump->{$cur_file}->{'PH'}->{STACK}) {
+ if (not defined $objdump->{$cur_file}{'PH'}{STACK}) {
if (defined $info->field('architecture')) {
my $arch = $info->field('architecture');
tag 'shlib-without-PT_GNU_STACK-section', $cur_file
if $stack_arches{$arch};
}
- } elsif ($objdump->{$cur_file}->{'PH'}->{STACK}->{flags} ne 'rw-'){
+ } elsif ($objdump->{$cur_file}{'PH'}{STACK}{flags} ne 'rw-'){
tag 'shlib-with-executable-stack', $cur_file;
}
} elsif ($ldconfig_dirs->known(dirname($cur_file))
diff --git a/checks/testsuite.pm b/checks/testsuite.pm
index ed9b7d4..a9de939 100644
--- a/checks/testsuite.pm
+++ b/checks/testsuite.pm
@@ -105,7 +105,7 @@ sub check_control_contents {
} else {
while (my ($index, $paragraph) = each(@paragraphs)) {
check_control_paragraph($info, $paragraph,
- $lines[$index]->{'START-OF-PARAGRAPH'});
+ $lines[$index]{'START-OF-PARAGRAPH'});
}
}
return;
diff --git a/lib/Lintian/Architecture.pm b/lib/Lintian/Architecture.pm
index 866a910..bb38012 100644
--- a/lib/Lintian/Architecture.pm
+++ b/lib/Lintian/Architecture.pm
@@ -104,9 +104,9 @@ sub _parse_arch {
my ($os, $cpu) = split /\s++/o, $raw;
# map $os-any (e.g. "linux-any") and any-$arch (e.g. "any-amd64") to
# the relevant architectures.
- $ARCH_WILDCARDS{"$os-any"}->{$archstr} = 1;
- $ARCH_WILDCARDS{"any-$cpu"}->{$archstr} = 1;
- $ARCH_WILDCARDS{'any'}->{$archstr} = 1;
+ $ARCH_WILDCARDS{"$os-any"}{$archstr} = 1;
+ $ARCH_WILDCARDS{"any-$cpu"}{$archstr} = 1;
+ $ARCH_WILDCARDS{'any'}{$archstr} = 1;
if ($os eq 'linux') {
my ($long, $short);
# Per Policy §11.1 (3.9.3):
@@ -226,7 +226,7 @@ sub wildcard_includes_arch {
# Load the wildcards if it has not been done yet.
$ARCH_RAW->known('any') unless %ARCH_WILDCARDS;
$arch = $ALT_ARCH_NAMES{$arch} if exists $ALT_ARCH_NAMES{$arch};
- return exists $ARCH_WILDCARDS{$wc}->{$arch} ? 1 : 0;
+ return exists $ARCH_WILDCARDS{$wc}{$arch} ? 1 : 0;
}
=back
diff --git a/lib/Lintian/CheckScript.pm b/lib/Lintian/CheckScript.pm
index 498245d..900a156 100644
--- a/lib/Lintian/CheckScript.pm
+++ b/lib/Lintian/CheckScript.pm
@@ -126,7 +126,7 @@ sub new {
if ($self->{'type'}//'ALL' ne 'ALL') {
$self->{'type-table'} = {};
for my $t (split /\s*,\s*/o, $self->{'type'}) {
- $self->{'type-table'}->{$t} = 1;
+ $self->{'type-table'}{$t} = 1;
}
}
@@ -136,7 +136,7 @@ sub new {
unless $pg->{'tag'};
$pg->{'info'} = $loc{$pg->{'tag'}} if exists $loc{$pg->{'tag'}};
$ti = Lintian::Tag::Info->new($pg, $self->{'name'}, $self->{'type'});
- $self->{'tag-table'}->{$ti->tag} = $ti;
+ $self->{'tag-table'}{$ti->tag} = $ti;
}
bless $self, $class;
@@ -194,7 +194,7 @@ inputs.
sub is_check_type {
my ($self, $type) = @_;
return 1 if ($self->{'type'}//'ALL') eq 'ALL';
- return $self->{'type-table'}->{$type};
+ return $self->{'type-table'}{$type};
}
=item $cs->get_tag ($tagname)
@@ -206,7 +206,7 @@ this check).
sub get_tag {
my ($self, $tag) = @_;
- return $self->{'tag-table'}->{$tag};
+ return $self->{'tag-table'}{$tag};
}
=item $cs->tags
diff --git a/lib/Lintian/CollScript.pm b/lib/Lintian/CollScript.pm
index 02122d7..d4245ae 100644
--- a/lib/Lintian/CollScript.pm
+++ b/lib/Lintian/CollScript.pm
@@ -81,7 +81,7 @@ sub new {
$self->{'auto_remove'} = 1
if lc($header->{'auto-remove'}//'') eq 'yes';
for my $t (split /\s*,\s*/o, $self->{'type'}) {
- $self->{'type-table'}->{$t} = 1;
+ $self->{'type-table'}{$t} = 1;
}
bless $self, $class;
@@ -116,9 +116,9 @@ sub _parse_needs {
push @max, $part unless exists $seen{$part};
}
}
- $self->{'needs_info'}->{'min'} = \@min;
- $self->{'needs_info'}->{'type'} = \%typespec;
- $self->{'needs_info'}->{'max'} = \@max;
+ $self->{'needs_info'}{'min'} = \@min;
+ $self->{'needs_info'}{'type'} = \%typespec;
+ $self->{'needs_info'}{'max'} = \@max;
return;
}
@@ -211,11 +211,11 @@ sub needs_info {
my $needs = $self->{'needs_info'};
my @min = @{ $needs->{'min'} };
my $type = $cond->{'type'};
- push @min, @{ $needs->{'type'}->{$type} }
- if exists $needs->{'type'}->{$type};
+ push @min, @{ $needs->{'type'}{$type} }
+ if exists $needs->{'type'}{$type};
return @min;
}
- return @{ $self->{'needs_info'}->{'max'} };
+ return @{ $self->{'needs_info'}{'max'} };
}
=item is_type (TYPE)
@@ -226,7 +226,7 @@ Returns a truth value if this collection can be applied to a TYPE package.
sub is_type {
my ($self, $type) = @_;
- return $self->{'type-table'}->{$type};
+ return $self->{'type-table'}{$type};
}
=item collect (PKG, TASK, DIR)
diff --git a/lib/Lintian/Collect/Binary.pm b/lib/Lintian/Collect/Binary.pm
index 5ca929d..fe6cc59 100644
--- a/lib/Lintian/Collect/Binary.pm
+++ b/lib/Lintian/Collect/Binary.pm
@@ -413,7 +413,7 @@ sub objdump_info {
if ($header eq 'RPATH') {
# RPATH is like PATH
foreach my $rpathcomponent (split(m/:/,$val)) {
- $info{$header}->{$rpathcomponent} = 1;
+ $info{$header}{$rpathcomponent} = 1;
}
} elsif ($header eq 'NEEDED' or $header eq 'SONAME') {
push @{ $info{$header} }, $val;
@@ -491,8 +491,8 @@ a hash containing the following keys:
A hash containing the contents of the JAR file manifest. For instance,
to find the classpath of I<$file>, you could use:
- if (exists $info->java_info->{$file}->{'manifest'}) {
- my $cp = $info->java_info->{$file}->{'manifest'}->{'Class-Path'};
+ if (exists $info->java_info->{$file}{'manifest'}) {
+ my $cp = $info->java_info->{$file}{'manifest'}{'Class-Path'};
# ...
}
@@ -538,16 +538,16 @@ sub java_info {
next if m/^\s*$/o;
if (m#^-- ERROR:\s*(\S.++)$#o) {
- $java_info{$file}->{error} = $1;
+ $java_info{$file}{error} = $1;
} elsif (m#^-- MANIFEST: (?:\./)?(?:.+)$#o) {
# TODO: check $file == $1 ?
- $java_info{$file}->{manifest} = {};
- $manifest = $java_info{$file}->{manifest};
+ $java_info{$file}{manifest} = {};
+ $manifest = $java_info{$file}{manifest};
$file_list = 0;
} elsif (m#^-- (?:\./)?(.+)$#o) {
$file = $1;
- $java_info{$file}->{files} = {};
- $file_list = $java_info{$file}->{files};
+ $java_info{$file}{files} = {};
+ $file_list = $java_info{$file}{files};
$manifest = 0;
} else {
if ($manifest && m#^ (\S+):\s(.*)$#o) {
@@ -596,7 +596,7 @@ Needs-Info requirements for using I<relation>: L<Same as field|Lintian::Collect/
sub relation {
my ($self, $field) = @_;
$field = lc $field;
- return $self->{relation}->{$field} if exists $self->{relation}->{$field};
+ return $self->{relation}{$field} if exists $self->{relation}{$field};
my %special = (
all => [qw(pre-depends depends recommends suggests)],
@@ -614,8 +614,8 @@ sub relation {
my $value = $self->field($field);
$result = Lintian::Relation->new($value);
}
- $self->{relation}->{$field} = $result;
- return $self->{relation}->{$field};
+ $self->{relation}{$field} = $result;
+ return $self->{relation}{$field};
}
=item is_pkg_class ([TYPE])
@@ -701,7 +701,7 @@ Needs-Info requirements for using I<is_conffile>: L<Same as control_index_resolv
sub is_conffile {
my ($self, $file) = @_;
if (exists $self->{'conffiles'}) {
- return 1 if exists $self->{'conffiles'}->{$file};
+ return 1 if exists $self->{'conffiles'}{$file};
return;
}
my $cf = $self->control_index_resolved_path('conffiles');
diff --git a/lib/Lintian/Collect/Changes.pm b/lib/Lintian/Collect/Changes.pm
index d872a67..6db579c 100644
--- a/lib/Lintian/Collect/Changes.pm
+++ b/lib/Lintian/Collect/Changes.pm
@@ -35,7 +35,7 @@ Lintian::Collect::Changes - Lintian interface to .changes file data collection
my $files = $collect->files();
foreach my $file (keys %{$files}) {
- my $size = $files->{$file}->{size};
+ my $size = $files->{$file}{size};
print "File $file has size $size\n";
}
diff --git a/lib/Lintian/Collect/Package.pm b/lib/Lintian/Collect/Package.pm
index 454a2a5..6014ab8 100644
--- a/lib/Lintian/Collect/Package.pm
+++ b/lib/Lintian/Collect/Package.pm
@@ -233,7 +233,7 @@ sub file_info {
$self->{file_info} = \%file_info;
return ${$self->{file_info}{$file}}
- if exists $self->{file_info}->{$file};
+ if exists $self->{file_info}{$file};
return;
}
@@ -583,7 +583,7 @@ sub _fetch_index_data {
# entry.
$idxh{$target}{'size'} = $e->{'size'} if exists($e->{'size'});
delete($e->{'size'});
- delete $idxh{$target}->{link};
+ delete $idxh{$target}{link};
}
}
}
@@ -622,7 +622,7 @@ sub _fetch_index_data {
$self->{"sorted_$field"} = \@sorted;
close($idx);
close($num_idx) if $num_idx;
- return $self->{$field}->{$file} if exists $self->{$field}->{$file};
+ return $self->{$field}{$file} if exists $self->{$field}{$file};
return;
}
diff --git a/lib/Lintian/Collect/Source.pm b/lib/Lintian/Collect/Source.pm
index e0312c8..189b4cb 100644
--- a/lib/Lintian/Collect/Source.pm
+++ b/lib/Lintian/Collect/Source.pm
@@ -221,8 +221,8 @@ Needs-Info requirements for using I<binary_package_type>: L<Same as binary_field
sub binary_package_type {
my ($self, $binary) = @_;
if (exists $self->{binaries}) {
- return $self->{binaries}->{$binary}
- if exists $self->{binaries}->{$binary};
+ return $self->{binaries}{$binary}
+ if exists $self->{binaries}{$binary};
return;
}
# we need the binary fields for this.
@@ -463,8 +463,8 @@ Needs-Info requirements for using I<binary_relation>: L<Same as binary_field|/bi
sub binary_relation {
my ($self, $package, $field) = @_;
$field = lc $field;
- return $self->{binary_relation}->{$package}->{$field}
- if exists $self->{binary_relation}->{$package}->{$field};
+ return $self->{binary_relation}{$package}{$field}
+ if exists $self->{binary_relation}{$package}{$field};
my %special = (
all => [qw(pre-depends depends recommends suggests)],
@@ -483,7 +483,7 @@ sub binary_relation {
my $value = $self->binary_field($package, $field);
$result = Lintian::Relation->new($value);
}
- $self->{binary_relation}->{$package}->{$field} = $result;
+ $self->{binary_relation}{$package}{$field} = $result;
return $result;
}
@@ -517,7 +517,7 @@ Needs-Info requirements for using I<relation>: L<Same as field|Lintian::Collect/
sub relation {
my ($self, $field) = @_;
$field = lc $field;
- return $self->{relation}->{$field} if exists $self->{relation}->{$field};
+ return $self->{relation}{$field} if exists $self->{relation}{$field};
my $result;
if ($field =~ /^build-(depends|conflicts)-all$/) {
diff --git a/lib/Lintian/DepMap.pm b/lib/Lintian/DepMap.pm
index fa27c05..9dd41bd 100644
--- a/lib/Lintian/DepMap.pm
+++ b/lib/Lintian/DepMap.pm
@@ -139,10 +139,10 @@ sub add {
}
$self->{'known'}{$node}++;
- $self->{'nodes'}{$node}->{'branches'} = {}
- unless(exists($self->{'nodes'}{$node}->{'branches'}));
- $self->{'nodes'}{$node}->{'parents'} = {}
- unless(exists($self->{'nodes'}{$node}->{'parents'}));
+ $self->{'nodes'}{$node}{'branches'} = {}
+ unless(exists($self->{'nodes'}{$node}{'branches'}));
+ $self->{'nodes'}{$node}{'parents'} = {}
+ unless(exists($self->{'nodes'}{$node}{'parents'}));
while (my $parent = pop @parents) {
$parents = 1;
@@ -153,12 +153,12 @@ sub add {
$self->{'unknown'}{$parent}++;
}
- $self->{'nodes'}{$parent}->{'branches'}->{$node}
+ $self->{'nodes'}{$parent}{'branches'}{$node}
= $self->{'nodes'}{$node};
- $self->{'nodes'}{$node}->{'parents'}->{$parent}
+ $self->{'nodes'}{$node}{'parents'}{$parent}
= $self->{'nodes'}{$parent};
}
- unless ($parents || scalar %{$self->{'nodes'}{$node}->{'parents'}}) {
+ unless ($parents || scalar %{$self->{'nodes'}{$node}{'parents'}}) {
$self->{'pending'}{$node} = 1;
} elsif (exists $self->{'pending'}{$node}) {
delete $self->{'pending'}{$node};
@@ -235,10 +235,10 @@ sub satisfy {
$self->{'satisfied_nodes'}{$node}
= [keys %{$self->{'nodes'}{$node}{'branches'}}];
- for my $branch (keys %{$self->{'nodes'}{$node}->{'branches'}}) {
- delete $self->{'nodes'}{$branch}->{'parents'}->{$node};
- delete $self->{'nodes'}{$node}->{'branches'}->{$branch};
- unless (scalar keys %{$self->{'nodes'}{$branch}->{'parents'}}) {
+ for my $branch (keys %{$self->{'nodes'}{$node}{'branches'}}) {
+ delete $self->{'nodes'}{$branch}{'parents'}{$node};
+ delete $self->{'nodes'}{$node}{'branches'}{$branch};
+ unless (scalar keys %{$self->{'nodes'}{$branch}{'parents'}}) {
$self->{'pending'}{$branch} = 1;
}
}
@@ -267,7 +267,7 @@ E.g.
sub done {
my $self = shift;
my $node = shift;
- return exists $self->{'satisfied_nodes'}->{$node};
+ return exists $self->{'satisfied_nodes'}{$node};
}
=item unlink(node)
@@ -311,13 +311,13 @@ sub unlink {
delete $self->{'selected'}{$node}
if (exists($self->{'selected'}{$node}));
- for my $parent (keys %{$self->{'nodes'}{$node}->{'parents'}}) {
+ for my $parent (keys %{$self->{'nodes'}{$node}{'parents'}}) {
delete $self->{'nodes'}{$parent}{'branches'}{$node}
if exists $self->{'nodes'}{$parent}{'branches'}{$node};
delete $self->{'nodes'}{$node}{'parents'}{$parent};
}
- for my $branch (keys %{$self->{'nodes'}{$node}->{'branches'}}) {
+ for my $branch (keys %{$self->{'nodes'}{$node}{'branches'}}) {
delete $self->{'nodes'}{$branch}{'parents'}{$node};
delete $self->{'nodes'}{$node}{'branches'}{$branch};
}
@@ -577,7 +577,7 @@ sub circular {
$self->initialise();
} else {
for my $node (keys %{$self->{'nodes'}}) {
- my $node_p = $self->{'nodes'}{$node}->{'parents'};
+ my $node_p = $self->{'nodes'}{$node}{'parents'};
push @circ, grep { exists $node_p->{$_} } keys %{$node_p};
}
}
diff --git a/lib/Lintian/DepMap/Properties.pm b/lib/Lintian/DepMap/Properties.pm
index 81b4819..cf7b84f 100644
--- a/lib/Lintian/DepMap/Properties.pm
+++ b/lib/Lintian/DepMap/Properties.pm
@@ -61,7 +61,7 @@ sub add {
} elsif (not ref($ref)) {
push @_, $ref;
} else {
- $self->{'properties'}->{$_[0]} = $ref;
+ $self->{'properties'}{$_[0]} = $ref;
}
return $self->SUPER::add(@_);
}
@@ -89,7 +89,7 @@ sub addp {
} elsif (not ref($ref)) {
push @_, $ref;
} else {
- $self->{'properties'}->{$_[0]} = $ref;
+ $self->{'properties'}{$_[0]} = $ref;
}
return $self->SUPER::addp(@_);
}
@@ -114,7 +114,7 @@ E.g.
sub getp {
my $self = shift;
my $node = shift;
- return $self->{'properties'}->{$node};
+ return $self->{'properties'}{$node};
}
1;
diff --git a/lib/Lintian/Lab/Entry.pm b/lib/Lintian/Lab/Entry.pm
index bb0d9b5..f8bbc95 100644
--- a/lib/Lintian/Lab/Entry.pm
+++ b/lib/Lintian/Lab/Entry.pm
@@ -324,7 +324,7 @@ Note: The version can be 0.
sub coll_version {
my ($self, $coll) = @_;
- return $self->{coll}->{$coll}//'';
+ return $self->{coll}{$coll}//'';
}
=item is_coll_finished (COLL, VERSION)
@@ -350,7 +350,7 @@ sub is_coll_finished {
# non-public method to mark a collection as complete
sub _mark_coll_finished {
my ($self, $coll, $version) = @_;
- $self->{coll}->{$coll} = $version;
+ $self->{coll}{$coll} = $version;
return 1;
}
@@ -359,7 +359,7 @@ sub _mark_coll_finished {
# Removes the notion that $coll has been finished.
sub _clear_coll_status {
my ($self, $coll) = @_;
- delete $self->{coll}->{$coll};
+ delete $self->{coll}{$coll};
return 1;
}
@@ -399,7 +399,7 @@ sub update_status_file {
@sc = sort keys %{ $self->{coll} };
print $sfd "Collections: \n";
- print $sfd ' ' . join(",\n ", map { "$_=$self->{coll}->{$_}" } @sc);
+ print $sfd ' ' . join(",\n ", map { "$_=$self->{coll}{$_}" } @sc);
print $sfd "\n\n";
close $sfd or return 0;
return 1;
diff --git a/lib/Lintian/Lab/Manifest.pm b/lib/Lintian/Lab/Manifest.pm
index f37a8e6..4a44c67e 100644
--- a/lib/Lintian/Lab/Manifest.pm
+++ b/lib/Lintian/Lab/Manifest.pm
@@ -59,7 +59,7 @@ the lab as caches.
The data structure is basically a tree (using hashes). For binaries
is looks (something) like:
- $self->{'state'}->{$name}->{$version}->{$architecture}
+ $self->{'state'}{$name}{$version}{$architecture}
The (order of the) fields used in the tree are listed in the
@{BIN,SRC,CHG}_QUERY lists below. The fields may (and generally do)
@@ -588,7 +588,7 @@ sub _do_set {
my $k;
# Find the hash where the entry should be stored
- # - The basic structure is "$root->{key1}->...->{keyN-1}->{keyN} = $entry"
+ # - The basic structure is "$root->{key1}->...->{keyN-1}{keyN} = $entry"
# - This loop is supposed to find the "n-1"th hash and save that in $cur.
# - After the loop, a simple "$cur->{$keyN} = $entry" inserts the element.
for (my $i = 0 ; $i < $qfl ; $i++) {
diff --git a/lib/Lintian/Path.pm b/lib/Lintian/Path.pm
index 5212986..ffaa6cb 100644
--- a/lib/Lintian/Path.pm
+++ b/lib/Lintian/Path.pm
@@ -388,14 +388,14 @@ symlinks, even if the symlink points to a file.
=cut
-sub is_symlink { return $_[0]->{'_path_info'} & TYPE_SYMLINK ? 1 : 0; }
-sub is_hardlink { return $_[0]->{'_path_info'} & TYPE_HARDLINK ? 1 : 0; }
-sub is_dir { return $_[0]->{'_path_info'} & TYPE_DIR ? 1 : 0; }
+sub is_symlink { return $_[0]{'_path_info'} & TYPE_SYMLINK ? 1 : 0; }
+sub is_hardlink { return $_[0]{'_path_info'} & TYPE_HARDLINK ? 1 : 0; }
+sub is_dir { return $_[0]{'_path_info'} & TYPE_DIR ? 1 : 0; }
sub is_file {
- return $_[0]->{'_path_info'} & (TYPE_FILE | TYPE_HARDLINK) ? 1 : 0;
+ return $_[0]{'_path_info'} & (TYPE_FILE | TYPE_HARDLINK) ? 1 : 0;
}
-sub is_regular_file { return $_[0]->{'_path_info'} & TYPE_FILE ? 1 : 0; }
+sub is_regular_file { return $_[0]{'_path_info'} & TYPE_FILE ? 1 : 0; }
=item link_normalized
diff --git a/lib/Lintian/Processable.pm b/lib/Lintian/Processable.pm
index a19b31f..cb8ff0a 100644
--- a/lib/Lintian/Processable.pm
+++ b/lib/Lintian/Processable.pm
@@ -151,7 +151,7 @@ sub new_from_metadata {
my $val;
$val = delete $self->{$k} unless exists $KEEP{$k};
if (defined $val && exists $KEEP_EXTRA{$k}) {
- $self->{'extra-fields'}->{$k} = $val;
+ $self->{'extra-fields'}{$k} = $val;
}
}
$self->_make_identifier;
@@ -297,8 +297,8 @@ sub get_field {
my ($self, $field, $def) = @_;
return $def
unless exists $self->{'extra-fields'}
- and exists $self->{'extra-fields'}->{$field};
- return $self->{'extra-fields'}->{$field}//$def;
+ and exists $self->{'extra-fields'}{$field};
+ return $self->{'extra-fields'}{$field}//$def;
}
=back
diff --git a/lib/Lintian/ProcessablePool.pm b/lib/Lintian/ProcessablePool.pm
index 7957132..66bdd8f 100644
--- a/lib/Lintian/ProcessablePool.pm
+++ b/lib/Lintian/ProcessablePool.pm
@@ -112,7 +112,7 @@ sub add_proc {
return 0;
}
$groupid = $self->_get_group_id($proc);
- $group = $self->{groups}->{$groupid};
+ $group = $self->{groups}{$groupid};
if (defined $group){
if ($pkg_type eq 'source'){
# if this is a source pkg, then this is a duplicate
@@ -125,7 +125,7 @@ sub add_proc {
# Create a new group
$group = Lintian::ProcessableGroup->new($self->{'lab'});
$group->add_processable($proc);
- $self->{groups}->{$groupid} = $group;
+ $self->{groups}{$groupid} = $group;
}
# add it to the "unprocessed"/"seen" map.
return 1;
@@ -153,7 +153,7 @@ if there is no group called $name.
sub get_group{
my ($self, $group) = @_;
- return $self->{groups}->{$group};
+ return $self->{groups}{$group};
}
=item $pool->get_groups()
@@ -191,7 +191,7 @@ sub _add_changes_file{
my $group = Lintian::ProcessableGroup->new($self->{'lab'}, $pkg_path);
my $cproc = $group->get_changes_processable();
my $gid = $self->_get_group_id($cproc);
- my $ogroup = $self->{groups}->{$gid};
+ my $ogroup = $self->{groups}{$gid};
if (defined($ogroup)){
# Group already exists...
my $added = 0;
@@ -215,7 +215,7 @@ sub _add_changes_file{
}
return $added;
} else {
- $self->{groups}->{$gid} = $group;
+ $self->{groups}{$gid} = $group;
}
return 1;
}
diff --git a/lib/Lintian/Profile.pm b/lib/Lintian/Profile.pm
index c782e9a..9a6d057 100644
--- a/lib/Lintian/Profile.pm
+++ b/lib/Lintian/Profile.pm
@@ -215,7 +215,7 @@ Returns a false value if the tag has been marked as
sub is_overridable {
my ($self, $tag) = @_;
- return !exists $self->{'non-overridable-tags'}->{$tag};
+ return !exists $self->{'non-overridable-tags'}{$tag};
}
=item $prof->get_tag ($tag[, $known])
@@ -228,8 +228,8 @@ Otherwise it returns undef.
sub get_tag {
my ($self, $tag, $known) = @_;
- return unless $known || exists $self->{'enabled-tags'}->{$tag};
- return $self->{'known-tags'}->{$tag};
+ return unless $known || exists $self->{'enabled-tags'}{$tag};
+ return $self->{'known-tags'}{$tag};
}
=item $prof->get_script ($script[, $known])
@@ -245,8 +245,8 @@ provides are enabled.
sub get_script {
my ($self, $script, $known) = @_;
- return unless $known || exists $self->{'enabled-checks'}->{$script};
- return $self->{'check-scripts'}->{$script};
+ return unless $known || exists $self->{'enabled-checks'}{$script};
+ return $self->{'check-scripts'}{$script};
}
=item $prof->enable_tags (@tags)
@@ -258,11 +258,11 @@ Enables all tags named in @tags. Croaks if an unknown tag is found.
sub enable_tags {
my ($self, @tags) = @_;
for my $tag (@tags) {
- my $ti = $self->{'known-tags'}->{$tag};
+ my $ti = $self->{'known-tags'}{$tag};
croak "Unknown tag $tag" unless $ti;
- next if exists $self->{'enabled-tags'}->{$tag};
- $self->{'enabled-tags'}->{$tag} = 1;
- $self->{'enabled-checks'}->{$ti->script}++;
+ next if exists $self->{'enabled-tags'}{$tag};
+ $self->{'enabled-tags'}{$tag} = 1;
+ $self->{'enabled-checks'}{$ti->script}++;
}
return;
}
@@ -276,12 +276,12 @@ Disable all tags named in @tags. Croaks if an unknown tag is found.
sub disable_tags {
my ($self, @tags) = @_;
for my $tag (@tags) {
- my $ti = $self->{'known-tags'}->{$tag};
+ my $ti = $self->{'known-tags'}{$tag};
croak "Unknown tag $tag" unless $ti;
- next unless exists $self->{'enabled-tags'}->{$tag};
- delete $self->{'enabled-tags'}->{$tag};
- delete $self->{'enabled-checks'}->{$ti->script}
- unless --$self->{'enabled-checks'}->{$ti->script};
+ next unless exists $self->{'enabled-tags'}{$tag};
+ delete $self->{'enabled-tags'}{$tag};
+ delete $self->{'enabled-checks'}{$ti->script}
+ unless --$self->{'enabled-checks'}{$ti->script};
}
return;
}
@@ -421,9 +421,9 @@ sub _read_profile_section {
foreach my $tag (@tags) {
croak "Unknown check $tag in $pname (section $sno)"
- unless $self->{'known-tags'}->{$tag};
+ unless $self->{'known-tags'}{$tag};
if ($severity) {
- $self->{'known-tags'}->{$tag}->set_severity($severity);
+ $self->{'known-tags'}{$tag}->set_severity($severity);
}
if ($overridable != -1) {
if ($overridable) {
@@ -455,17 +455,17 @@ sub _read_profile_tags{
my $tags_from_check_sub = sub {
my ($field, $check) = @_;
- unless (exists $self->{'check-scripts'}->{$check}) {
+ unless (exists $self->{'check-scripts'}{$check}) {
$self->_load_check($pname, $check);
}
- return $self->{'check-scripts'}->{$check}->tags;
+ return $self->{'check-scripts'}{$check}->tags;
};
my $tag_sub = sub {
my ($field, $tag) = @_;
- unless (exists $self->{'known-tags'}->{$tag}) {
+ unless (exists $self->{'known-tags'}{$tag}) {
$self->_load_checks;
croak "Unknown tag \"$tag\" in profile \"$pname\""
- unless exists $self->{'known-tags'}->{$tag};
+ unless exists $self->{'known-tags'}{$tag};
}
return $tag;
};
@@ -473,7 +473,7 @@ sub _read_profile_tags{
for
my $check ($self->_split_comma_sep_field($pheader->{'load-checks'})){
$self->_load_check($pname, $check)
- unless exists $self->{'check-scripts'}->{$check};
+ unless exists $self->{'check-scripts'}{$check};
}
}
$self->_enable_tags_from_field($pname, $pheader, 'enable-tags-from-check',
@@ -594,26 +594,26 @@ sub _parse_check {
my ($self, $gcname, $dir) = @_;
# Have we already tried to load this before? Possibly via an alias
# or symlink
- return $self->{'check-scripts'}->{$gcname}
- if exists $self->{'check-scripts'}->{$gcname};
+ return $self->{'check-scripts'}{$gcname}
+ if exists $self->{'check-scripts'}{$gcname};
my $c= Lintian::CheckScript->new($dir, $gcname,$self, $self->{'language'});
my $cname = $c->name;
- if (exists $self->{'check-scripts'}->{$cname}) {
+ if (exists $self->{'check-scripts'}{$cname}) {
# We have loaded the check under a different name
- $c = $self->{'check-scripts'}->{$cname};
+ $c = $self->{'check-scripts'}{$cname};
# Record the alias so we don't have to parse the check file again.
- $self->{'check-scripts'}->{$gcname} = $c;
+ $self->{'check-scripts'}{$gcname} = $c;
return $c;
}
- $self->{'check-scripts'}->{$cname} = $c;
- $self->{'check-scripts'}->{$gcname} = $c if $gcname ne $cname;
+ $self->{'check-scripts'}{$cname} = $c;
+ $self->{'check-scripts'}{$gcname} = $c if $gcname ne $cname;
for my $tn ($c->tags) {
- if ($self->{'known-tags'}->{$tn}) {
- my $ocn = $self->{'known-tags'}->{$tn}->script;
+ if ($self->{'known-tags'}{$tn}) {
+ my $ocn = $self->{'known-tags'}{$tn}->script;
croak "$cname redefined tag $tn which was defined by $ocn";
}
- $self->{'known-tags'}->{$tn} = $c->get_tag($tn);
+ $self->{'known-tags'}{$tn} = $c->get_tag($tn);
}
return $c;
}
diff --git a/lib/Lintian/Relation.pm b/lib/Lintian/Relation.pm
index 9ec7520..a71c066 100644
--- a/lib/Lintian/Relation.pm
+++ b/lib/Lintian/Relation.pm
@@ -335,14 +335,14 @@ sub duplicates {
my $first = $self->unparse($self_i);
my $second = $self->unparse($self_j);
if ($seen{$first}) {
- $dups{$seen{$first}}->{$second} = $j;
+ $dups{$seen{$first}}{$second} = $j;
$seen{$second} = $seen{$first};
} elsif ($seen{$second}) {
- $dups{$seen{$second}}->{$first} = $i;
+ $dups{$seen{$second}}{$first} = $i;
$seen{$first} = $seen{$second};
} else {
$dups{$first} ||= {};
- $dups{$first}->{$second} = $j;
+ $dups{$first}{$second} = $j;
$seen{$second} = $first;
}
}
diff --git a/lib/Lintian/Unpacker.pm b/lib/Lintian/Unpacker.pm
index 73d4fae..dd0e3d4 100644
--- a/lib/Lintian/Unpacker.pm
+++ b/lib/Lintian/Unpacker.pm
@@ -270,7 +270,7 @@ sub _gen_type_coll {
$cmap->initialise;
- $self->{'cache'}->{$pkg_type} = $cmap;
+ $self->{'cache'}{$pkg_type} = $cmap;
return $cmap->clone;
}
@@ -281,10 +281,10 @@ sub _requested_colls {
my $pkg_type = $lpkg->pkg_type;
my ($cmap, %needed, @check);
- unless (exists $self->{'cache'}->{$pkg_type}) {
+ unless (exists $self->{'cache'}{$pkg_type}) {
$cmap = $self->_gen_type_coll($pkg_type);
} else {
- $cmap = $self->{'cache'}->{$pkg_type}->clone;
+ $cmap = $self->{'cache'}{$pkg_type}->clone;
}
# if its new and $profile is undef, we have to run all
@@ -513,7 +513,7 @@ sub process_tasks {
foreach my $procid (keys %$worklists) {
# Failed ones do not count...
next if $failed{$procid};
- my $cmap = $worklists->{$procid}->{'collmap'};
+ my $cmap = $worklists->{$procid}{'collmap'};
if ($cmap->pending) {
$done = 0;
last;
diff --git a/private/graph b/private/graph
index 6ea02f0..29fdd42 100755
--- a/private/graph
+++ b/private/graph
@@ -136,7 +136,7 @@ sub gen_depth_level {
foreach my $other (@{ $rneeds{$node} }) {
next unless $other =~ m/^coll-/o;
next if exists $depth{$other};
- delete $re{$other}->{$node};
+ delete $re{$other}{$node};
# Is this the last edge to this node?
next if scalar keys %{ $re{$other} };
# Yes, then we visit it.
@@ -185,7 +185,7 @@ sub mark_longest_paths {
foreach my $node (@c) {
foreach my $dep (@{ $needs{$node} }) {
next unless $depth{"coll-$dep"} == $next;
- $path_marks->{$node}->{"coll-$dep"} = 1;
+ $path_marks->{$node}{"coll-$dep"} = 1;
push @nc, "coll-$dep";
}
}
@@ -206,7 +206,7 @@ sub make_graph {
print "\n// Edges\n";
foreach my $sn (sort keys %edges) {
foreach my $en (sort keys %{ $edges{$sn} }) {
- my ($et, $attr) = @{ $edges{$sn}->{$en} };
+ my ($et, $attr) = @{ $edges{$sn}{$en} };
my $e = "\"$sn\" $et \"$en\"";
$e .= " [ $attr ]" if $attr;
print " $e\n";
@@ -220,7 +220,7 @@ sub make_graph {
sub is_marked {
my ($paths, $start, $end) = @_;
return unless $paths;
- return unless exists $paths->{$start} && exists $paths->{$start}->{$end};
+ return unless exists $paths->{$start} && exists $paths->{$start}{$end};
return 1;
}
diff --git a/private/refresh-archs b/private/refresh-archs
index dbc9039..e3db99c 100755
--- a/private/refresh-archs
+++ b/private/refresh-archs
@@ -194,11 +194,11 @@ exit 0;
sub write_data_line {
my ($vars) = @_;
foreach my $filename (keys %files) {
- my $fd = $files{$filename}->{'fd'};
- foreach my $orig (@{ $files{$filename}->{'line-spec'} }) {
+ my $fd = $files{$filename}{'fd'};
+ foreach my $orig (@{ $files{$filename}{'line-spec'} }) {
my $line = $orig; # copy the template
$line =~ s#\@([^@ \t]+)\@#$vars->{$1}//die "Unknown var: $1"#eg;
- push @{ $files{$filename}->{'lines'} }, $line;
+ push @{ $files{$filename}{'lines'} }, $line;
}
}
return;
@@ -209,23 +209,23 @@ sub open_data_files {
my $date = strftime '%Y-%m-%d', gmtime;
foreach my $filename (keys %files) {
my ($fd, $temp) = tempfile();
- $files{$filename}->{'temp-file'} = $temp;
- $files{$filename}->{'fd'} = $fd;
- $files{$filename}->{'lines'} = [];
- if ($files{$filename}->{'header'}) {
- print $fd $files{$filename}->{'header'};
+ $files{$filename}{'temp-file'} = $temp;
+ $files{$filename}{'fd'} = $fd;
+ $files{$filename}{'lines'} = [];
+ if ($files{$filename}{'header'}) {
+ print $fd $files{$filename}{'header'};
}
print $fd "# Last updated: $date\n";
print $fd "# With: $version\n";
print $fd "# This file was auto-generated by $0\n";
- if ($files{$filename}->{'keep'}) {
+ if ($files{$filename}{'keep'}) {
open(my $orig, '<', "$datapath/$filename");
print $fd "#\n# Lines to always be include\n";
while (my $line = <$orig>) {
next unless $line =~ m/^#\s*Keep:\s*(.*\S)\s*$/io;
my $v = $1;
print $fd "# Keep: $v\n";
- push @{ $files{$filename}->{'lines'} }, $v;
+ push @{ $files{$filename}{'lines'} }, $v;
}
close($orig);
}
@@ -246,15 +246,15 @@ sub add_data_file {
sub close_and_rename {
foreach my $filename (keys %files) {
- my $tf = $files{$filename}->{'temp-file'};
- my $fd = $files{$filename}->{'fd'};
- foreach my $line (sort @{ $files{$filename}->{'lines'} }) {
+ my $tf = $files{$filename}{'temp-file'};
+ my $fd = $files{$filename}{'fd'};
+ foreach my $line (sort @{ $files{$filename}{'lines'} }) {
print $fd "$line\n";
}
- close($files{$filename}->{'fd'});
+ close($files{$filename}{'fd'});
}
foreach my $filename (keys %files) {
- my $tf = $files{$filename}->{'temp-file'};
+ my $tf = $files{$filename}{'temp-file'};
my $df = "$datapath/$filename";
system('mv', '-f', $tf, $df) == 0 or die "mv -f $tf $df failed.\n";
}
diff --git a/reporting/html_reports b/reporting/html_reports
index 1d7ecc3..2052fc5 100755
--- a/reporting/html_reports
+++ b/reporting/html_reports
@@ -423,7 +423,7 @@ sub collect_statistics {
}
if (@$tags) {
$sources_ref->{$source}{$version}
- = $tags->[0]->{pkg_info}{xref};
+ = $tags->[0]{pkg_info}{xref};
}
}
$qa_list_ref->{$source} = \%count;
diff --git a/t/scripts/Lintian/Lab/Manifest/01-basic.t b/t/scripts/Lintian/Lab/Manifest/01-basic.t
index b257618..633eee6 100755
--- a/t/scripts/Lintian/Lab/Manifest/01-basic.t
+++ b/t/scripts/Lintian/Lab/Manifest/01-basic.t
@@ -28,7 +28,7 @@ $plist->visit_all(sub { my ($v, @k) = @_; push @contents, $v; push @keys, \@k}
);
is(@contents, 1, 'Contents one element');
-is($contents[0]->{'source'}, $input->{'source'}, 'Element has the right name');
+is($contents[0]{'source'}, $input->{'source'}, 'Element has the right name');
# Change input, output should be unaffected
$input->{'file'} = 'lalalala';
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: