Bug#829744: marked as done (Add new-package-should-not-package-python2-module tag)
Your message dated Mon, 26 Dec 2016 16:33:30 +0000
with message-id <E1cLYDK-000CP4-QN@fasolo.debian.org>
and subject line Bug#829744: fixed in lintian 2.5.50
has caused the Debian Bug report #829744,
regarding Add new-package-should-not-package-python2-module tag
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
829744: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829744
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: Add new-package-should-not-package-python2-module tag
- From: Chris Lamb <lamby@debian.org>
- Date: Tue, 05 Jul 2016 20:20:56 +0200
- Message-id: <1467742856.1750917.657606953.4511FB0F@webmail.messagingengine.com>
Source: lintian
Version: 2.5.45
Severity: wishlist
Tags: patch
X-Debbugs-CC: python-modules-team@lists.alioth.debian.org
Hi,
Attached is the following:
commit 51a7a2a34804af18c1a103f87c2a482372200e1b
Author: Chris Lamb <lamby@debian.org>
Date: Tue Jul 5 20:14:00 2016 +0200
Add new-package-should-not-package-python2-module tag
The 2.x series of Python is due for deprecation and will not be maintained
past 2020 so it is recommended that Python 2 modules are not packaged
unless necessary.
Signed-off-by: Chris Lamb <lamby@debian.org>
checks/scripts.desc | 13 +++++++++++++
checks/scripts.pm | 7 +++++++
t/tests/scripts-python2/debian/debian/control.in | 15 +++++++++++++++
t/tests/scripts-python2/desc | 8 ++++++++
t/tests/scripts-python2/tags | 1 +
5 files changed, 44 insertions(+)
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org / chris-lamb.co.uk
`-
From 51a7a2a34804af18c1a103f87c2a482372200e1b Mon Sep 17 00:00:00 2001
From: Chris Lamb <lamby@debian.org>
Date: Tue, 5 Jul 2016 20:14:00 +0200
Subject: [PATCH] Add new-package-should-not-package-python2-module tag
The 2.x series of Python is due for deprecation and will not be maintained
past 2020 so it is recommended that Python 2 modules are not packaged
unless necessary.
Signed-off-by: Chris Lamb <lamby@debian.org>
---
checks/scripts.desc | 13 +++++++++++++
checks/scripts.pm | 7 +++++++
t/tests/scripts-python2/debian/debian/control.in | 15 +++++++++++++++
t/tests/scripts-python2/desc | 8 ++++++++
t/tests/scripts-python2/tags | 1 +
5 files changed, 44 insertions(+)
create mode 100644 t/tests/scripts-python2/debian/debian/control.in
create mode 100644 t/tests/scripts-python2/desc
create mode 100644 t/tests/scripts-python2/tags
diff --git a/checks/scripts.desc b/checks/scripts.desc
index 12a642b..87a0c29 100644
--- a/checks/scripts.desc
+++ b/checks/scripts.desc
@@ -752,3 +752,16 @@ Severity: classification
Certainty: possible
Info: The maintainer scripts of the package one or more auto-generated
shell snippets inserted by the listed debhelper tool.
+
+Tag: new-package-should-not-package-python2-module
+Severity: wishlist
+Certainty: certain
+Info: This package appears to be the first packaging of a new upstream
+ software package but it appears to package a module for Python 2.
+ .
+ The 2.x series of Python is due for deprecation and will not be maintained
+ past 2020 so it is recommended that Python 2 modules are not packaged unless
+ necessary.
+ .
+ This warning can be ignored if the package is not intended for Debian or
+ if it is a split of an existing Debian package.
diff --git a/checks/scripts.pm b/checks/scripts.pm
index 5959e95..de4fcd7 100644
--- a/checks/scripts.pm
+++ b/checks/scripts.pm
@@ -1103,6 +1103,13 @@ sub run {
}
}
+ my @entries = $info->changelog->data;
+
+ if (@entries == 1) {
+ tag 'new-package-should-not-package-python2-module', $pkg
+ if $pkg =~ /^python-/
+ }
+
return;
}
diff --git a/t/tests/scripts-python2/debian/debian/control.in b/t/tests/scripts-python2/debian/debian/control.in
new file mode 100644
index 0000000..993dee7
--- /dev/null
+++ b/t/tests/scripts-python2/debian/debian/control.in
@@ -0,0 +1,15 @@
+Source: {$source}
+Priority: extra
+Section: python
+Maintainer: {$author}
+Standards-Version: {$standards_version}
+Build-Depends: debhelper (>= 9)
+
+Package: python-{$source}
+Architecture: all
+Depends: $\{misc:Depends\}, python2.7
+Description: {$description}
+ This is a test package designed to exercise some feature or tag of
+ Lintian. It is part of the Lintian test suite and may do very odd
+ things. It should not be installed like a regular package. It may
+ be an empty package.
diff --git a/t/tests/scripts-python2/desc b/t/tests/scripts-python2/desc
new file mode 100644
index 0000000..56dba16
--- /dev/null
+++ b/t/tests/scripts-python2/desc
@@ -0,0 +1,8 @@
+Testname: scripts-python2
+Sequence: 6000
+Version: 1.0
+Description: Check various Python 2 issues
+Skeleton: pedantic
+Options: --pedantic -I -E
+Test-For:
+ new-package-should-not-package-python2-module
diff --git a/t/tests/scripts-python2/tags b/t/tests/scripts-python2/tags
new file mode 100644
index 0000000..685f534
--- /dev/null
+++ b/t/tests/scripts-python2/tags
@@ -0,0 +1 @@
+I: python-scripts-python2: new-package-should-not-package-python2-module python-scripts-python2
--
2.8.1
--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.5.50
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 829744@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 26 Dec 2016 16:07:20 +0000
Source: lintian
Binary: lintian
Architecture: source
Version: 2.5.50
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
lintian - Debian package checker
Closes: 685029 740161 743599 801760 818962 829744 834867 839822 842781 843406 843595 844903 845201 847318 847535 847558
Changes:
lintian (2.5.50) unstable; urgency=medium
.
* Summary of tag changes:
+ Added:
- invalid-value-in-built-using-field
- license-problem-convert-utf-code
- new-package-should-not-package-python2-module
- php-script-but-no-php-cli-dep
- php-script-with-unusual-interpreter
+ Removed:
- php-script-but-no-phpX-cli-dep
.
* checks/binaries.{desc,pm}:
+ [NT] Handle RUNPATH like we handle RPATH. (Closes: #844903)
+ [NT] Update hardening-no-pie description to reflect that
PIE is on by default in Debian.
* checks/cruft.desc:
+ [BR] Detect utf convert non free code.
(Closes: #843595)
* checks/deb-format.pm:
+ [NT] Permit uncompressed {control,data}.tar members plus xz
compressed control.tar files in deb files. Thanks to
Guillem Jover for the report. (Closes: #834867)
* checks/debhelper.pm:
+ [BR] Apply patch from Yann Soubeyrand :
"Allow debhelper "--with" addons to be quoted".
(Closes: #839822)
* checks/files.{desc,pm}:
+ [NT] Check for invalid clauses in "Built-Using" fields. Thanks to
Andrey Rahmatullin for the suggestion. (Closes: #847558)
+ [NT] Apply patch from Josh Triplett to add new sections to
descriptions.
* checks/files.desc:
+ [NT] Document that we no longer accept "virtual packages"
for deliberately empty packages. If your package receives
an "empty-binary-package" tag, please replace the use of
"virtual package".
* checks/{files,scripts}.pm:
+ [NT] Apply patch from Josh Triplett to exclude files under
/usr/share/cargo/registry/ from a few checks as that directory
contains unmodified upstream sources. (Closes: #845201)
* checks/manpages.pm:
+ [JW, NT] Fix false negative manpage-named-after-build-path
for packages built by sbuild. (Closes: #801760)
* checks/scripts.{desc,pm}:
+ [JW, NT] Apply patch from Antonio Ospite that updates the
test for php scripts without a php-cli dependency. Thanks
to Ondřej Surý for the report and Mathieu Parent for the
initial patch. (Closes: #818962)
+ [CL, NT] Warn about new source packages providing a python2
package as EOL for python2 is expected in 2020, which is
before buster's expected EOL. (Closes: #829744)
.
* collection/objdump-info.desc:
+ [NT] Bump version due to RUNPATH collection.
.
* commands/lintian:
+ [NT] Deprecate --fail-on-warnings, which will be removed in
Debian/buster.
.
* data/binaries/embedded-libs:
+ [BR] Allow openssl1.0 as source package. (Closes: #843406).
* data/debhelper/dh_commands-manual:
+ [NT] Apply patch from Piotr Ożarowski that ensure that
consumers of dh_python2 Build-Depends on dh-python.
(Closes: #740161)
* data/fields/archive-sections:
+ [NT] Apply patch from Josh Triplett to add javascript and
rust sections. (Closes: #847535)
* data/files/privacy-breaker-websites:
+ [BR] Detect more logos.
* data/scripts/interpreters:
+ [NT] Apply patch from Antonio Ospite to correct a false
positive warning for python scripts using python2 in the
shebang line. Thanks to Per Andersson for the report and
Luca Boccassi for the initial patch for solving this.
(Closes: #743599)
* data/spelling/corrections:
+ [PW] Add more corrections.
* data/spelling/corrections-case:
+ [EG] Correct spelling of Lua (Closes: #842781)
.
* helpers/coll/objdump-info-helper:
+ [NT] Extract RUNPATH from binaries as well.
.
* lib/Lintian/Collect/Binary.pm:
+ [NT] Expose RUNPATH when set in the binary.
+ [NT] Remove "virtual package" from the list of phrases
marking a package as a meta-package. Thanks to Stuart
Prescott for the report. (Closes: #685029)
.
* profiles/kali/main.profile:
+ [NT] Add a profile for Kali Linux. Thanks to Raphaël
Hertzog for the report. (Closes: #847318)
.
* vendors/kali/main/data/changes-file/known-dists:
+ [NT] Add data file for Kali Linux.
Checksums-Sha1:
9e69721de46eb0403e965146fa27f811a51c08ab 2813 lintian_2.5.50.dsc
ac88ebc4a38039e6e05371549763316c425d645e 1234588 lintian_2.5.50.tar.xz
Checksums-Sha256:
afcd908621b0f54cba88e5dd91582a15846eba6c92e93d49743e8a8c7cd203e9 2813 lintian_2.5.50.dsc
3d0888655ae4b875f514cb3c18b0e17af51c1086a8fcaf8316ddd677f8668224 1234588 lintian_2.5.50.tar.xz
Files:
fe16926a354d4744346ff35d12ca7f0d 2813 devel optional lintian_2.5.50.dsc
a7864b677db4df8360a4b2f50c42314f 1234588 devel optional lintian_2.5.50.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEsxMaRR2/33ygW0GXBUu7n32AZEIFAlhhQ+QACgkQBUu7n32A
ZELTdw//b+WBlkGT/bD0Gfzm6ZLH9F42yEKKstzyMlEJugMWH61ibXKTisHHYwxP
rIfFlOR0n754LfH0Y+jPvPHFLgakVSxGdXnIFmkFSptHA/RjOvNm3zUgNVKShKtV
X58V9tHBYAZTmMX6Cv6VMkTW4tvYe/gJL1ucDiPOxe6JCsFwzsQSDyDtlMNLdTTB
aFZ0NjXcnaVnIiniapWIcfXq0TDedaJ5R2YzY3OpSPTDIVIfLQzVIzNnLHakoRyh
aBmpK/xLBjBKZpXqZSrqky4beg/myD2DqaV1+jH5oku4g7A8okIRmwimDdZjSlqe
ilVpR4+YyZC+de/c/PETarh6k0EGT71mrBJUVq9DmJqzIvlfHrEbZVaHA0d4aXAh
WHQhQ2+UU7VuRjsiirAyA0Bz5+mIDLzgrM4pZRNW/+R58YfUWLxvoCYXLIIdj/yv
gKel0u8veiob8aKcEDanin2TMl+SKegxqwRd418PjAcZUQldYDL1oOQV+JEd/mCb
q9W47vJD51h5/SvRLEdBQ4ZKhqNV2+U7KIMTAcg6thsCO8iJT+eZrb1HL6lqPL76
LbCuSTVQ5qlG0l/9zEWJrrXzFvTigUadxAt5FNjAYIb8yBdE4WjX2D9SNYbrs05g
Rtstmpxv+b6BpxzSm8gvpvm/kvsBMxfPNtGLr8AcdCf8TYKMz98=
=ertm
-----END PGP SIGNATURE-----
--- End Message ---
Reply to: