Bug#828723: lintian: Please warn on deprecated usage of LD_LIBRARY_PATH for dpkg-shlibdeps

[Guillem Jover <guillem@debian.org>]

Package: lintian
Version: 2.5.45
Severity: wishlist

Hi!

The dpkg-shlibdeps commands gained a new -l option in dpkg 1.17.0 to
avoid having to use LD_LIBRARY_PATH for host libraries on the build
system. Which is a problem because that variable is a run-time one,
not build-time, so adding random paths there might have ill-effects
on the build system, particularly when cross-compiling.

It would be nice if lintian could emit warnings for any package that
sets that variable either directly before dpkg-shlibdeps or
dh_shlibdeps, or exports it globally from debian/rules or any of its
makefile included snippets. I guess such simplistic check would
trigger for valid usage such as running test suites and similar, but
I think it's worth the pain.

I'd like to completely deprecate reading from that variable in
dpkg-shlibdeps relatively soon, but it's one of those that I cannot
emit warnings from within dpkg-shlibdeps. :( So I cannot prepare a
normal transition.

Thanks,
Guillem