[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: L::Data: Remove some redundant conditionals



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 1324a220960b9fab51228e43a621864b6b7302e3
Author: Niels Thykier <niels@thykier.net>
Date:   Fri Feb 12 18:55:11 2016 +0000

    L::Data: Remove some redundant conditionals
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 lib/Lintian/Data.pm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/Lintian/Data.pm b/lib/Lintian/Data.pm
index e0f958c..b79e709 100644
--- a/lib/Lintian/Data.pm
+++ b/lib/Lintian/Data.pm
@@ -184,10 +184,9 @@ sub _parse_file {
             ($key, $val) = split(/$separator/, $line, 2);
             if ($code) {
                 my $pval = $dataset->{$key};
-                $val = $code->($key, $val, $pval) if $code;
-                next if !defined $val && defined $pval;
-                unless (defined $val) {
-                    next if defined $pval;
+                $val = $code->($key, $val, $pval);
+                if (not defined($val)) {
+                    next if defined($pval);
                     croak "undefined value for $key (data-name: $data_name)";
                 }
             }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: