[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#807695: lintian: false positive for command-with-path-in-maintainer-script



Re: Thorsten Glaser 2015-12-11 <144985238932.307.13054893134096729173.reportbug@tglase.lan.tarent.de>
> I got a false positive for FusionForge in sid:
> 
> W: gforge-db-postgresql: command-with-path-in-maintainer-script postinst:8 /usr/bin/pg_lsclusters
> […]
> N:    See particularly the function pathfind() in devref.
> 
> The line in question:
> 
> if [ -x /usr/bin/pg_lsclusters ]; then

Hi,

postgresql-9.5.postrm has exactly the same problem:

    # if we still have the postgresql-common package, use it to also shutdown
    # server, etc.; otherwise just remove the directories
    if [ -x /usr/bin/pg_dropcluster ]; then
        pg_dropcluster --stop-server $VERSION "$1"
    else
        # remove data directory

I think test -x is a legitimate use case here, and using "which"
instead would just mean using a Debian-specific tool, making the code
less readable for sh programmers (... not to mention the extra fork()).

Can we have that whitelisted in lintian please?

Christoph
-- 
cb@df7cb.de | http://www.df7cb.de/

Attachment: signature.asc
Description: PGP signature


Reply to: