[lintian] 05/08: c/binaries: Avoid calling getter without using the value
This is an automated email from the git hooks/post-receive script.
nthykier pushed a commit to branch master
in repository lintian.
commit b85f711b796e36005fca443c588feb57891a4f26
Author: Niels Thykier <niels@thykier.net>
Date: Mon Jan 25 18:40:46 2016 +0000
c/binaries: Avoid calling getter without using the value
Signed-off-by: Niels Thykier <niels@thykier.net>
---
checks/binaries.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/checks/binaries.pm b/checks/binaries.pm
index 72380d3..740b917 100644
--- a/checks/binaries.pm
+++ b/checks/binaries.pm
@@ -256,8 +256,7 @@ sub run {
# process all files in package
foreach my $file ($info->sorted_index) {
- my $fname = $file->name;
- my ($fileinfo, $objdump);
+ my ($fileinfo, $objdump, $fname);
next if not $file->is_file;
@@ -273,6 +272,7 @@ sub run {
tag 'arch-independent-package-contains-binary-or-object',$file;
}
+ $fname = $file->name;
if ($fname =~ m,^etc/,) {
tag 'binary-in-etc', $file;
}
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: