[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/03: html_reports: Create an extract_name_and_email sub



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 969fc1e4a26259458b4b15aa4dfc81d4e11e0b56
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Jan 24 10:57:03 2016 +0000

    html_reports: Create an extract_name_and_email sub
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 reporting/html_reports | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/reporting/html_reports b/reporting/html_reports
index f1128e4..657a5b5 100755
--- a/reporting/html_reports
+++ b/reporting/html_reports
@@ -282,9 +282,8 @@ for my $maintainer (@maintainers) {
 
     # Determine the parts of the maintainer and the file name for the
     # maintainer page.
-    my ($name, $email) = ($maintainer =~ /^(.*) <([^>]+)>/);
-    $name = 'Unknown Maintainer' unless $name;
-    $email = 'unknown' unless $email;
+    my ($name, $email) = extract_name_and_email($maintainer);
+
     my $regular = "maintainer/$id";
     my $full = "full/$id";
 
@@ -324,8 +323,7 @@ output_template('maintainers.html', $templates{maintainers}, \%data);
 # Now, generate stub pages for every maintainer who has only clean packages.
 for my $id (keys %clean) {
     my $maintainer = $clean{$id};
-    my ($name, $email) = ($maintainer =~ /^(.*) <([^>]+)>/);
-    $email = 'unknown' unless $email;
+    my ($name, $email) = extract_name_and_email($maintainer);
     my %maint_data = (
         id         => $id,
         email      => html_quote(uri_escape($email)),
@@ -469,6 +467,14 @@ sub collect_statistics {
     return;
 }
 
+sub extract_name_and_email {
+    my ($maintainer) = @_;
+    my ($name, $email) = ($maintainer =~ /^(.*) <([^>]+)>/);
+    $name = 'Unknown Maintainer' unless $name;
+    $email = 'unknown' unless $email;
+    return ($name, $email);
+}
+
 # Generate the package lists.  These are huge, so we break them into four
 # separate pages.
 #

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: