[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: t/runtests: Remove unused variables



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 5d9866a085acf31590f6369c69d768fecf77160b
Author: Niels Thykier <niels@thykier.net>
Date:   Wed Jan 20 22:55:10 2016 +0000

    t/runtests: Remove unused variables
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 t/runtests | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/t/runtests b/t/runtests
index 53364a9..582d164 100755
--- a/t/runtests
+++ b/t/runtests
@@ -108,8 +108,6 @@ chomp $DATE;
 my $output_is_tty = -t STDOUT;
 
 our $IO_LOOP = IO::Async::Loop->new;
-our $OUTPUT_IS_TTY = -t STDOUT;
-our %OPT;
 
 # --- Parsed options / arguments
 
@@ -179,7 +177,7 @@ find_tests_to_run();
 
 if (@TESTS) {
     for my $i (0..$JOBS-1) {
-        create_child($IO_LOOP, \@TESTS, $i)
+        create_child($IO_LOOP, \@TESTS)
           or last;
     }
 
@@ -419,8 +417,7 @@ sub _builder_tests {
     $test_state->progress('building');
     my $res = chdir_runcmd($testdir, \@DPKG_BUILDPACKAGE_CMD, $log);
     if ($res){
-        my $pkg = $testdata->{source};
-        $test_state->dump_log($pkg, $log) if $DUMP_LOGS;
+        $test_state->dump_log($log) if $DUMP_LOGS;
         fail("cd $testdir && @DPKG_BUILDPACKAGE_CMD >$log 2>&1");
     }
 
@@ -481,7 +478,6 @@ sub run_lintian {
 # passes and false if it fails.
 sub test_changes {
     my ($test_state, $testdata) = @_;
-    my $testname = $testdata->{testname};
 
     if (!check_test_is_sane($TESTSET, $testdata)) {
         return $test_state->skip_test('architecture mismatch');
@@ -582,8 +578,7 @@ sub generic_test_runner {
         my $res= chdir_runcmd($targetdir, ['fakeroot', 'make'],
             "../build.$testname");
         if ($res) {
-            $test_state->dump_log($testname,
-                "${RUNDIR}/${suite}/build.${testname}")
+            $test_state->dump_log("${RUNDIR}/${suite}/build.${testname}")
               if $DUMP_LOGS;
             return $test_state->test_error(
                 join(q{ },
@@ -692,7 +687,7 @@ sub run_prove_tests {
 }
 
 sub create_child {
-    my ($loop, $tests, $child_no) = @_;
+    my ($loop, $tests) = @_;
     my ($child_in_ch, $child_out_ch, $routine);
     my $start_test = shift(@{$tests});
 
@@ -1103,7 +1098,7 @@ sub test_error {
 }
 
 sub dump_log {
-    my ($self, $pkg, $logfile) = @_;
+    my ($self, $logfile) = @_;
     return $self->_send('dump-file', $logfile);
 }
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: