[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#797556: lintian: False positive in maintainer-script-should-not-use-adduser-system-without-home if --system comes after --home



Control: forcemerge 797395 -1

On Mon, Aug 31, 2015 at 04:03:44PM +0200, Chris Lamb wrote:
> Package: lintian
> Version: 2.5.36.1
> 
> Hi,
> 
> There is a false positive in the
> "maintainer-script-should-not-use-adduser-system-without-home" tag if
> the --system argument comes after --home.
> 
> Whilst the adduser manpage suggests this wouldn't work, adduser will
> happily accept it. For example:
> 
>   		adduser \
> 			    --home /var/lib/redis \
> 			    --quiet \
> 			    --system \
> 			    --group \
> 			    ${USER}
> 
> .. appears to work fine, but Lintian warns.
> 
> Looking at the regex for this tag in
> data/scripts/maintainer-script-bad-command indicates why (ie. enforced
> ordering on the line), but my regex-fu is not strong enough to support
> either ordering without essentially duplicating the line, hence no "Tag:
> patch".
> 
> Of course, it might also be acceptable to wontfix this not accept this
> variant - I am unsure of the Lintian policy in this area.

This got fixed just some hours ago :)
https://anonscm.debian.org/cgit/lintian/lintian.git/commit/?id=1d6b8a0a24c4bc477fd188964484f9480b76bce2

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: Digital signature


Reply to: