[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#797395: [maintainer-script-should-not-use-adduser-system-without-home] false positivies



Hi,

Jakub Wilk wrote:
> * Axel Beckert <abe@debian.org>, 2015-08-30, 21:08:
> >The regexp is now surely uglier and less readable than before. So
> >I wonder what we could do to improve the situation inside
> >data/scripts/maintainer-script-bad-command
> 
> I'd suggest removing the tag from the data file, and re-implementing
> it in (readable) Perl.

Actually that was my third option in mind _until_ I found the
way to tackle that issue.

But where to make the cut? Just because a regexp uses "(?!…)"? Surely
not! Or because it is too long? Doesn't sound like a valid reason
either.

I'd rather make it even longer using the /x flag and then being able
to add comments.

But that will again break with the one-line-per-entry design of that
file.

Anyway: I think we should _generally_ improve the situation and not
duplicating functionality for a single tag.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE


Reply to: