[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 02/02: c/fields.pm: New tags libmodule-build(-tiny)-perl-needs-to-be-in-build-depends



This is an automated email from the git hooks/post-receive script.

abe pushed a commit to branch ppt-lc-mover
in repository lintian.

commit 2103f3d3c5bb37c2174b4ed006be6abd0b9128ff
Author: Axel Beckert <abe@deuxchevaux.org>
Date:   Thu Aug 13 18:00:10 2015 +0200

    c/fields.pm: New tags libmodule-build(-tiny)-perl-needs-to-be-in-build-depends
    
    Moved over from pkg-perl-tools. Written by gregor herrmann.
    
    Signed-off-by: Axel Beckert <abe@deuxchevaux.org>
---
 checks/fields.desc                                      | 12 ++++++++++++
 checks/fields.pm                                        | 17 +++++++++++++++++
 debian/changelog                                        |  2 ++
 .../fields-module-build-perl/debian/debian/control.in   | 16 ++++++++++++++++
 t/tests/fields-module-build-perl/debian/debian/rules    |  4 ++++
 t/tests/fields-module-build-perl/desc                   |  7 +++++++
 t/tests/fields-module-build-perl/tags                   |  2 ++
 7 files changed, 60 insertions(+)

diff --git a/checks/fields.desc b/checks/fields.desc
index 714e7fe..58300e0 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1246,3 +1246,15 @@ Severity: normal
 Certainty: certain
 Info: The use of "current" in the Python-Version field is deprecated.
 Ref: python-policy 3.4
+
+Tag: libmodule-build-perl-needs-to-be-in-build-depends
+Severity: serious
+Certainty: certain
+Info: libmodule-build-perl needs to be in <tt>Build-Depends</tt>, not in
+ Build-Depends-Indep, since it's used in the clean target.
+
+Tag: libmodule-build-tiny-perl-needs-to-be-in-build-depends
+Severity: serious
+Certainty: certain
+Info: libmodule-build-tiny-perl needs to be in <tt>Build-Depends</tt>, not
+ in Build-Depends-Indep, since it's used in the clean target.
diff --git a/checks/fields.pm b/checks/fields.pm
index bceb3ef..23d7cbc 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -1165,6 +1165,23 @@ sub run {
         if ($arch_dep_packages == 0 and $build_all->implies($PYTHON_DEV)) {
             tag 'build-depends-on-python-dev-with-no-arch-any';
         }
+
+        # libmodule-build-perl
+        # matches() instead of implies() because of possible OR releation
+        if ($info->relation('build-depends-indep')
+            ->matches(qr/^libmodule-build-perl/, VISIT_PRED_NAME)
+            && !$info->relation('build-depends')
+            ->matches(qr/^libmodule-build-perl/, VISIT_PRED_NAME)) {
+            tag 'libmodule-build-perl-needs-to-be-in-build-depends';
+        }
+
+        # libmodule-build-tiny-perl
+        if ($info->relation('build-depends-indep')
+            ->implies('libmodule-build-tiny-perl')
+            && !$info->relation('build-depends')
+            ->implies('libmodule-build-tiny-perl')) {
+            tag 'libmodule-build-tiny-perl-needs-to-be-in-build-depends';
+        }
     }
 
     #----- Origin
diff --git a/debian/changelog b/debian/changelog
index 61a4641..bd85e7b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -21,6 +21,8 @@ lintian (2.5.36) UNRELEASED; urgency=medium
       suffixes (-gtk, -el, -nox, lucid)
     + [AB] Add an imaginary future emacs222 package to the test suite's
       dummy package to check for depends-on-old-emacs false positives.
+    + [AB] Add libmodule-build(-tiny)-perl-needs-to-be-in-build-depends
+      tags from pkg-perl-tools by gregor herrmann.
   * checks/files.desc:
     + [BR] Correct a few typos.  (Closes: #794953)
     + [BR] Rename files-privacybreach-may-use-debian-package
diff --git a/t/tests/fields-module-build-perl/debian/debian/control.in b/t/tests/fields-module-build-perl/debian/debian/control.in
new file mode 100644
index 0000000..b8a0092
--- /dev/null
+++ b/t/tests/fields-module-build-perl/debian/debian/control.in
@@ -0,0 +1,16 @@
+Source: {$source}
+Priority: extra
+Section: {$section}
+Maintainer: {$author}
+Standards-Version: {$standards_version}
+Build-Depends: debhelper (>= 9)
+Build-Depends-Indep: libmodule-build-perl, libmodule-build-tiny-perl
+
+Package: {$source}
+Architecture: {$architecture}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: {$description}
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.
diff --git a/t/tests/fields-module-build-perl/debian/debian/rules b/t/tests/fields-module-build-perl/debian/debian/rules
new file mode 100755
index 0000000..2d33f6a
--- /dev/null
+++ b/t/tests/fields-module-build-perl/debian/debian/rules
@@ -0,0 +1,4 @@
+#!/usr/bin/make -f
+
+%:
+	dh $@
diff --git a/t/tests/fields-module-build-perl/desc b/t/tests/fields-module-build-perl/desc
new file mode 100644
index 0000000..b6cbc06
--- /dev/null
+++ b/t/tests/fields-module-build-perl/desc
@@ -0,0 +1,7 @@
+Testname: fields-module-build-perl
+Sequence: 6000
+Version: 1.0
+Description: Test some libmodule-build(-tiny)-perl checks
+Test-For:
+ libmodule-build-perl-needs-to-be-in-build-depends
+ libmodule-build-tiny-perl-needs-to-be-in-build-depends
diff --git a/t/tests/fields-module-build-perl/tags b/t/tests/fields-module-build-perl/tags
new file mode 100644
index 0000000..8432ddb
--- /dev/null
+++ b/t/tests/fields-module-build-perl/tags
@@ -0,0 +1,2 @@
+E: fields-module-build-perl source: libmodule-build-perl-needs-to-be-in-build-depends
+E: fields-module-build-perl source: libmodule-build-tiny-perl-needs-to-be-in-build-depends

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: