[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: t: Improve a test to emit fewer unrelated tags



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 993e86098453e9ee1c37593ee75590e5519d7c2e
Author: Niels Thykier <niels@thykier.net>
Date:   Wed Aug 12 09:19:53 2015 +0200

    t: Improve a test to emit fewer unrelated tags
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 t/COVERAGE                                    | 6 ++----
 t/tests/files-wrong-owner/debian/debian/rules | 6 +++---
 t/tests/files-wrong-owner/desc                | 1 +
 t/tests/files-wrong-owner/tags                | 4 ----
 4 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/t/COVERAGE b/t/COVERAGE
index cb440f9..dd77ca5 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,5 +1,5 @@
-Last generated 2015-07-22
-Coverage (Tags): 1071/1138 (94.11%), w. legacy tests: 1128/1138 (99.12%)
+Last generated 2015-08-12
+Coverage (Tags): 1076/1142 (94.22%), w. legacy tests: 1132/1142 (99.12%)
 Coverage (Checks): 38/46 (82.61%), w. legacy tests: 41/46 (89.13%)
 
 The following tags are not tested by the test suite:
@@ -30,7 +30,6 @@ files package-contains-upstream-install-documentation
 files script-in-usr-share-doc
 files script-with-language-extension
 files use-of-compat-symlink
-files wrong-file-owner-uid-or-gid
 
 init.d duplicate-updaterc.d-calls-in-postrm
 init.d init.d-script-has-bad-lsb-line
@@ -139,7 +138,6 @@ filenames
   desktop-file-in-wrong-dir
   package-contains-devhelp-file-without-symlink
   use-of-compat-symlink
-  wrong-file-owner-uid-or-gid
 
 foo++
 
diff --git a/t/tests/files-wrong-owner/debian/debian/rules b/t/tests/files-wrong-owner/debian/debian/rules
index d26c319..37c2293 100644
--- a/t/tests/files-wrong-owner/debian/debian/rules
+++ b/t/tests/files-wrong-owner/debian/debian/rules
@@ -6,13 +6,13 @@ FILESDIR=debian/$(PKG)/usr/lib/filenames
 %:
 	dh $@
 
-override_dh_builddeb:
+override_dh_fixperms:
+	dh_fixperms
+	# Create some files with invalid ownership *after* dh_fixperms
 	mkdir -p $(FILESDIR)
-	# Create some files with invalid ownership.
 	set -e; for owner in 100:0 0:2001 30001:65535 65535:65001; do \
 	      touch $(FILESDIR)/wrong-owner-$$owner ; \
 	      chmod 644 $(FILESDIR)/wrong-owner-$$owner ; \
 	      chown "$$owner" $(FILESDIR)/wrong-owner-$$owner ; \
 	done
-	dh_builddeb
 
diff --git a/t/tests/files-wrong-owner/desc b/t/tests/files-wrong-owner/desc
index e333a60..11b2298 100644
--- a/t/tests/files-wrong-owner/desc
+++ b/t/tests/files-wrong-owner/desc
@@ -2,3 +2,4 @@ Testname: files-wrong-owner
 Sequence: 6000
 Version: 1.0
 Description: Test for wrong owner files in the deb
+Test-For: wrong-file-owner-uid-or-gid
diff --git a/t/tests/files-wrong-owner/tags b/t/tests/files-wrong-owner/tags
index 6851c7d..7289154 100644
--- a/t/tests/files-wrong-owner/tags
+++ b/t/tests/files-wrong-owner/tags
@@ -2,7 +2,3 @@ E: files-wrong-owner: wrong-file-owner-uid-or-gid usr/lib/filenames/wrong-owner-
 E: files-wrong-owner: wrong-file-owner-uid-or-gid usr/lib/filenames/wrong-owner-100:0 100/0
 E: files-wrong-owner: wrong-file-owner-uid-or-gid usr/lib/filenames/wrong-owner-30001:65535 30001/65535
 E: files-wrong-owner: wrong-file-owner-uid-or-gid usr/lib/filenames/wrong-owner-65535:65001 65535/65001
-W: files-wrong-owner: file-missing-in-md5sums usr/lib/filenames/wrong-owner-0:2001
-W: files-wrong-owner: file-missing-in-md5sums usr/lib/filenames/wrong-owner-100:0
-W: files-wrong-owner: file-missing-in-md5sums usr/lib/filenames/wrong-owner-30001:65535
-W: files-wrong-owner: file-missing-in-md5sums usr/lib/filenames/wrong-owner-65535:65001

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: