[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 03/03: application-not-library: Please perltidy and perlcritic



This is an automated email from the git hooks/post-receive script.

abe pushed a commit to branch ppt-lc-mover
in repository lintian.

commit f3e71ec66bfd6bbc80dbae1e18b2174a70ff59bf
Author: Axel Beckert <abe@deuxchevaux.org>
Date:   Tue Aug 11 14:12:11 2015 +0200

    application-not-library: Please perltidy and perlcritic
---
 checks/application-not-library.pm | 47 ++++++++++++++++++++++-----------------
 1 file changed, 26 insertions(+), 21 deletions(-)

diff --git a/checks/application-not-library.pm b/checks/application-not-library.pm
index 01dbaa7..51a238c 100644
--- a/checks/application-not-library.pm
+++ b/checks/application-not-library.pm
@@ -1,6 +1,6 @@
 # application-not-library -- find applications packaged like a library -*- perl -*-
 #
-# Copyright © 2014 Axel Beckert <abe@debian.org>
+# Copyright © 2014-2015 Axel Beckert <abe@debian.org>
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -26,34 +26,39 @@ use warnings;
 use Lintian::Tags qw(tag);
 
 sub run {
-    my ( $pkg, $type, $info, $proc, $group ) = @_;
+    my ($pkg, $type, $info, $proc, $group) = @_;
 
     return if # Big exception list for all tags
-        $pkg =~ /^perl(-base)?$/                    or # perl itself
-        $pkg =~ /^ruby[\d.]*$/                      or # ruby itself
-        $pkg =~ /^python[\d.]*(-dev|-minimal)?$/    or # python itself
-        $pkg =~ /^cpan(plus|minus)$/                or # cpan package managers
-        $pkg =~ /^libmodule-.*-perl$/               or # perl module tools
-        $pkg =~ /^libdevel-.*-perl$/                or # perl debugging tools
-        $pkg =~ /^libperl.*-perl$/                  or # perl-handling tools
-        $pkg =~ /^libtest-.*-perl$/                 or # perl testing tools
-        $pkg =~ /^python[\d.]*-(stdeb|setuptools)$/ or # python packaging stuff
-        $pkg =~ /^gem2deb/                          or # ruby packaging stuff
-        $pkg =~ /^xulrunner/                        or # rendering engine
-        $pkg =~ /^lib.*-(utils|tools|bin|dev)/      or # generic library helpers
-        grep { $pkg eq $_ } qw(rake bundler coderay kdelibs-bin); # whitelist
+      $pkg =~ /^perl(-base)?$/                    or # perl itself
+      $pkg =~ /^ruby[\d.]*$/                      or # ruby itself
+      $pkg =~ /^python[\d.]*(-dev|-minimal)?$/    or # python itself
+      $pkg =~ /^cpan(plus|minus)$/                or # cpan package managers
+      $pkg =~ /^libmodule-.*-perl$/               or # perl module tools
+      $pkg =~ /^libdevel-.*-perl$/                or # perl debugging tools
+      $pkg =~ /^libperl.*-perl$/                  or # perl-handling tools
+      $pkg =~ /^libtest-.*-perl$/                 or # perl testing tools
+      $pkg =~ /^python[\d.]*-(stdeb|setuptools)$/ or # python packaging stuff
+      $pkg =~ /^gem2deb/                          or # ruby packaging stuff
+      $pkg =~ /^xulrunner/                        or # rendering engine
+      $pkg =~ /^lib.*-(utils|tools|bin|dev)/      or # generic library helpers
+      scalar(
+        grep { $pkg eq $_ }
+          qw(rake bundler coderay kdelibs-bin)       # whitelist
+      );
 
     my @programs = ();
     foreach my $binpath (qw(bin sbin usr/bin usr/sbin usr/games)) {
         my $bindir = $info->index("$binpath/");
         next unless $bindir;
 
-        push(@programs,
-             grep { !/update$/ }     # ignore library maintenance tools
-             grep { !/properties$/ } # ignore library configuration tools
-             map { $_->name; }
-             grep { $_->basename !~ /^dh_/ } # ignore debhelper plugins
-             $bindir->children);
+        push(
+            @programs,
+            grep { !/update$/ }       # ignore library maintenance tools
+              grep { !/properties$/ } # ignore library configuration tools
+              map { $_->name; }
+              grep { $_->basename !~ /^dh_/ } # ignore debhelper plugins
+              $bindir->children
+        );
     }
 
     return unless @programs;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: