[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Tags naming convention



Hi!

On Sat, 2015-08-08 at 21:16:13 +0200, Bastien ROUCARIES wrote:
> On Sat, Aug 8, 2015 at 9:02 PM, Guillem Jover <guillem@debian.org> wrote:
> > I've noticed the recent addition of tags with either very confusing
> > names like:
> >
> > - debian-watch-may-check-gpg-signature
> >
> >   As reported in #735040, where the suggested name seems way better:
> >   debian-watch-does-not-check-for-gpg-signature
> 
> Ok but they are some override.

Would it e possible then, to rename the tag but map the override to
the new name? lintian could even warn on the use of the obsolete tag
name perhaps? This way the tags would keep working, and maintainers
would notice they need to rename them.

Here follows a list of proposals, you might want to wait for others
to comment or review the names though. Some I had doubts about I've
marked with “?”.

> > - privacy-breach-may-use-debian-package
> >
> >   Does the privacy breach use the package? A better name could perhaps be:
> >   privacy-breach-uses-embedded-file
> 
> renamed.

Thanks!

There's also the new tag:

- maintainer-script-may-use-dir_to_symlink_helper

  ?
  maintainer-script-uses-ln-command-for-dir-to-symlink-switch

> > Or names that instead of stating the detected fact, seem to dictate what
> > it would like to see.
> >
> > - file-should-not-be-compressed

file-is-compressed

> > - debian-rules-should-not-automatically-update-control

debian-rules-automatically-updates-control

> > - debian-rules-should-not-use-DEB_BUILD_OPTS

debian-rules-uses-DEB_BUILD_OPTS

> > - debian-rules-should-not-use-or-modify-user-only-variable

debian-rules-uses-or-modifies-user-only-variable

> > - debian-rules-should-not-use-pwd

debian-rules-uses-pwd

> > - debian-rules-should-not-use-underscore-variable

debian-rules-uses-underscore-variable

> > - maintainer-script-should-not-hide-init-failure

maintainer-script-hides-init-failure

> > - maintainer-script-should-not-modify-ld-so-conf

maintainer-script-modifies-ld-so-conf

> > - maintainer-script-should-not-modify-netbase-managed-file

maintainer-script-modifies-netbase-managed-file

> > - maintainer-script-should-not-use-adduser-system-without-home

maintainer-script-uses-adduser-system-without-home

> > - maintainer-script-should-not-use-ancient-dpkg-epoch-check

maintainer-script-uses-ancient-dpkg-epoch-check

> > - maintainer-script-should-not-use-ancient-dpkg-multi-conrep-check

maintainer-script-uses-ancient-dpkg-multi-conrep-check

> > - maintainer-script-should-not-use-deprecated-chown-usage

maintainer-script-uses-deprecated-chown-usage

> > - maintainer-script-should-not-use-dpkg-status-directly

maintainer-script-uses-dpkg-status-directly

> > - maintainer-script-should-not-use-fc-cache

maintainer-script-uses-fc-cache

> > - maintainer-script-should-not-use-gconftool

maintainer-script-uses-gconftool

> > - maintainer-script-should-not-use-install-sgmlcatalog

maintainer-script-uses-install-sgmlcatalog

> > - maintainer-script-should-not-use-service

maintainer-script-uses-service

> > - maintainer-script-should-not-use-start-stop-daemon

maintainer-script-uses-start-stop-daemon

> > - maintainer-script-should-not-use-update-alternatives-remove

maintainer-script-uses-update-alternatives-remove

> > - maintainer-script-should-not-use-update-alternatives-set

maintainer-script-uses-update-alternatives-set


> > # -must-not-
> >
> > - udeb-postinst-must-not-call-ldconfig

udeb-postinst-calls-ldconfig

> > # -should-not-
> >
> > - web-application-should-not-depend-unconditionally-on-apache2

web-application-depends-unconditionally-on-apache2

> > - orphaned-package-should-not-have-uploaders

orphaned-package-has-uploaders

> > - changelog-should-not-mention-nmu

changelog-mentions-nmu

> > - debian-revision-should-not-be-zero

debian-revision-is-zero

> > - library-in-debug-or-profile-should-not-be-stripped

library-in-debug-or-profile-is-stripped

> > # -might-not-
> >
> > - description-synopsis-might-not-be-phrased-properly

?
description-synopsis-is-a-sentence
description-synopsis-ends-with-dot

> > # -should-
> >
> > - changelog-should-mention-nmu

changelog-does-not-mention-nmu

> > - changelog-should-mention-qa

changelog-does-not-mention-qa

> > - clean-should-be-satisfied-by-build-depends

clean-is-not-satisfied-by-build-depends

> > - copyright-should-refer-to-common-license-file-for-apache-2

copyright-does-not-refer-to-common-license-file-for-apache-2

> > - copyright-should-refer-to-common-license-file-for-gfdl

copyright-does-not-refer-to-common-license-file-for-gfdl

> > - copyright-should-refer-to-common-license-file-for-gpl

copyright-does-not-refer-to-common-license-file-for-gpl

> > - copyright-should-refer-to-common-license-file-for-lgpl

copyright-does-not-refer-to-common-license-file-for-lgpl

> > - debian-watch-file-should-dversionmangle-not-uversionmangle

?
debian-watch-file-mangles-debian-version-with-uversionmangle

> > - debian-watch-file-should-mangle-version

debian-watch-file-does-not-mangle-version

> > - debian-watch-file-should-use-sf-redirector

debian-watch-file-does-not-use-sf-redirector

> > - debian-watch-file-should-uversionmangle-not-dversionmangle

?
debian-watch-file-mangles-upstream-version-with-dversionmangle

> > - debug-file-should-use-detached-symbols

debug-file-does-not-use-detached-symbols

> > - debug-package-should-be-named-dbg

debug-package-is-not-named-dbg

> > - debug-package-should-be-priority-extra

debug-package-is-not-priority-extra

> > - games-package-should-be-section-games

games-package-is-not-section-games

> > - init.d-script-should-depend-on-virtual-facility

init.d-script-does-not-depend-on-virtual-facility

> > - menu-method-should-include-menu-h

menu-method-does-not-include-menu-h

> > - new-package-should-close-itp-bug

new-package-does-not-close-itp-bug

> > - postrm-should-call-ldconfig

postrm-does-not-call-ldconfig

> > - symlink-should-be-absolute

symlink-is-not-absolute

> > - symlink-should-be-relative

symlink-is-not-relative

> > - transitional-package-should-be-oldlibs-extra

transitional-package-is-not-oldlibs-extra

Thanks,
Guillem


Reply to: