Bug#787853: marked as done (lintian: Do not complain about lack of LFS from local implementations)
Your message dated Sat, 08 Aug 2015 13:35:32 +0000
with message-id <E1ZO4Hc-0007jr-Uf@franck.debian.org>
and subject line Bug#787853: fixed in lintian 2.5.35
has caused the Debian Bug report #787853,
regarding lintian: Do not complain about lack of LFS from local implementations
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
787853: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=787853
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: lintian: Do not complain about lack of LFS from local implementations
- From: Guillem Jover <guillem@debian.org>
- Date: Fri, 5 Jun 2015 19:17:07 +0200
- Message-id: <20150605171706.GA28899@gaara.hadrons.org>
Package: lintian
Version: 2.5.31
Severity: wishlist
Tags: lfs
Hi!
I was checking the tags for inetutils when I noticed that inetutils-ftpd
is marked as binary-file-built-without-LFS-support, but only that binary
out of all binaries. The build system enables LFS, and the relevant files
include <config.h> before anything else.
So after that, my suspicion was that lintian might be detecting a tainted
symbol. And I remembered that gnulib provides its local implementation of
FTS, one that is compatible with LFS. objdump confirms that the local
symbols are visible, so it seems to me lintian is tripping on those.
Here's a small test case:
,---
#include <stddef.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fts.h>
#ifdef LOCAL_FTS
extern FTS *fts_open(char * const *paths, int flags,
int (*compar)(const FTSENT **, const FTSENT **)) { return NULL; }
extern int fts_close(FTS *fts) { return 0; }
#endif
int main() {
char *paths[] = { NULL };
FTS *fts = fts_open(paths, 0, NULL);
return fts_close(fts);
}
`---
By default (after stripping) it produces this «objdump -T» output:
,---
fts: file format elf32-i386
DYNAMIC SYMBOL TABLE:
00000000 DF *UND* 00000000 GLIBC_2.0 fts_open
00000000 DF *UND* 00000000 GLIBC_2.0 fts_close
00000000 w D *UND* 00000000 __gmon_start__
00000000 DF *UND* 00000000 GLIBC_2.0 __libc_start_main
0804850c g DO .rodata 00000004 Base _IO_stdin_used
`---
which should trigger the lintian tag. But when defining LOCAL_FTS:
,---
fts: file format elf32-i386
DYNAMIC SYMBOL TABLE:
00000000 w D *UND* 00000000 __gmon_start__
00000000 DF *UND* 00000000 GLIBC_2.0 __libc_start_main
0804840b g DF .text 0000000a Base fts_open
080484ec g DO .rodata 00000004 Base _IO_stdin_used
08048415 g DF .text 0000000a Base fts_close
`---
it should not. So I think that, to avoid false-positives, only undefined
symbols should be considered.
Thanks,
Guillem
--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.5.35
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 787853@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bastien Roucariès <roucaries.bastien+debian@gmail.com> (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 06 Aug 2015 10:50:49 +0200
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.35
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Bastien Roucariès <roucaries.bastien+debian@gmail.com>
Description:
lintian - Debian package checker
Closes: 787853 789820 793613 793908 794196 794505 794674
Changes:
lintian (2.5.35) unstable; urgency=medium
.
* Summary of tag changes:
+ Added:
- non-consecutive-debian-revision
- package-uses-experimental-debhelper-compat-version
- package-uses-old-debhelper-compat-version
.
* checks/binaries.pm:
+ [NT] Apply patch from Sebastian Andrzej Siewior to inhibit
binary-file-built-without-LFS-support tags for binaries
that contains the "offending" LFS symbol. These tend to
come from gnulib and be LFS compliant. Thanks to Guillem
Jover for the report. (Closes: #787853)
* checks/changelog-file.{desc,pm}:
+ [BR] Detect non consecutive debian revision. (Closes: #789820)
* checks/control-file.{desc,pm}:
+ [BR] In order to ease the multiarch-support removal the
severity of pre-depends-directly-on-multiarch-support tag
is raised to important. Thanks to Helmut Grohne for
the reminder.
+ [BR] pre-depends-directly-on-multiarch-support does not need
debhelper for being raised. Suggest to build-depends on
debhelper >= 9.
* checks/debhelper.{desc,pm}:
+ [BR] Use data file for pedantic warning on debhelper depends
version.
+ [BR] Detect not recommended and experimental debhelper version.
* checks/fields.desc:
+ [JW] Fix spelling of the word "indicate".
* checks/scripts.desc:
+ [BR] Document why adduser --no-create-home
is a bad idea for system user. (Closes: #793613).
.
* data/cruft/warn-file-type:
+ [BR] Detect pascal resource file source. (Closes: #793908).
* data/files/fonts:
+ [BR] Refresh this file. (Closes: #794196)
* data/scripts/maintainer-script-bad-command:
+ [BR] Detect more case of
maintainer-script-should-not-use-adduser-system-without-home.
+ [BR] Print offending line for
maintainer-script-should-not-use-adduser-system-without-home.
* data/spelling/corrections*:
+ [JW] Fix correction for "acknowldegement".
+ [JW] Document that the lists should be sorted.
+ [JW] Re-sort the correction lists and remove duplicates.
+ [JW] Add more corrections.
+ [BR] Add existant||existent correction.
.
* mail-templates/license-problem-*:
+ [JW] Make the files end with newline character.
+ [JW] Fix typo in template.
.
* private/refresh-manual-refs:
+ [JW] Update the list of required packages.
.
* t/scripts/*.t:
+ [JW] Make all the scripts executable.
* t/tests/changelog-file-strange-date/*:
+ [BR] Create a test with error syntax in changelog date.
Run only with dpkg below 1.18.2. (Closes: #794674).
* t/tests/binaries-general/*:
+ [BR] Fix a test suite failure with gcc5 by using compat 9, and
removing gets() that does not exist with C11 (used by default
by gcc5). (Closes: #794505).
* t/tests/legacy-binary/debian/debian/rules:
+ [BR] Improve clean rule, thanks to Jakub Wilk.
Checksums-Sha1:
617036dfb5dd0d456c14140fec15b6136d8c787f 2731 lintian_2.5.35.dsc
7d1d24b164d2c2ae9b0fceff35d677cb50330696 1225948 lintian_2.5.35.tar.xz
47c7aeaee0fd216d339e18c8cdaa06a791461dd4 823220 lintian_2.5.35_all.deb
Checksums-Sha256:
a1c4de23b65311549c7b0cdd142e7a1085d0ae41e38c0b992ef4a0bc902111ab 2731 lintian_2.5.35.dsc
c266268c1d9f756b7e88d270e5898f472ae5d0321903fb0ea3d09ea7b96aa7f3 1225948 lintian_2.5.35.tar.xz
0d9d28b15e72423ca247c768a3a961e0df2fcc2b6006421623ec309e9c6b3e21 823220 lintian_2.5.35_all.deb
Files:
288536aabca2a3a6953d0411d1405272 2731 devel optional lintian_2.5.35.dsc
f8b0c76d60e44e5dab16c25223e7167d 1225948 devel optional lintian_2.5.35.tar.xz
b3ab8442e84453f7eae3be932be7b875 823220 devel optional lintian_2.5.35_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJVxgMgAAoJEGvmY8daNcl1NKYP/jjwBGmf5McMZ5dmhwqeaJUO
el3EL1w4Y6kjvNjm1nrfy5QLUxNuuPOxRGpFozHJfseMwv1sx7RWDyGUJ9UIY8/u
Oi4KnMDzNDzd6xYZV07KHBiw06sF4URnx1T+/QgzyNLknqZznDE/xyn15LtIeMtv
sVd/Upgv+8HlfP08TsVK4Yb5hEWJjYkukaURG/zr7R8s2rt4HnK2w1jyuWWSDZaG
VyCQCO+aUouiJmv/uLTm7Juwc5VucKuGWqiDINN8ClElGjncGSmCLbXWOTrSwfFf
7noarNHYpHFWDJOJEoR158H+PbzqpdK3MXpmsiaUbtCbn04zEXjOmHs1fpgGE20f
TTDhMt5SBxJQqKng6pzA8vN3hnaZTd3apBQK2k0MqvNA9EdXZUu/m2kWuMasqHyF
xfRRNZH+DTZDoJ/jmFF/roE8H60q4y9IA7F0ODEemglLFySjxrk5F8nDEfeBfUP/
sBHJpXsL4Vy+Y9sSlcXNb9gx1bptiAJ5dvgopspL2/Iv3RkH5hlCIW8TsXFu2jNa
S/q2HFdWmaE7S2Bs/U/EiFm6wuovtudtRnznpB/1D8QetNDRnWhp2K1NWqKNeLY4
BXLcSf7bZLgpDZwfx7xC4zq90v42gbReTrkzGMiyrUMlEFwPhMQE11JdKoRmX4kT
ywrw3guW0Uf/Su1hL+a8
=P9zs
-----END PGP SIGNATURE-----
--- End Message ---
Reply to: