Re: [lintian] 01/01: Fix a test suite failure with gcc5
On Mon, Aug 3, 2015 at 10:33 PM, Jakub Wilk <jwilk@debian.org> wrote:
> * Bastien ROUCARIES <broucaries-guest@moszumanska.debian.org>, 2015-08-03,
> 19:48:
>>
>> - /* Bad choice for reading from stdin, but it forces a stack
>> + /* Bad choice for reading from a security point of view, but it
>> forces a stack
>> protector, so meh.
>
>
> This sentence sounds awkward (as if "security point of view" was the thing
> we're reading from). I'd replace this comment with something simple:
>
> /* Force stack protector: */
>
> or remove it altogether.
>
>> + if(argc > 0)
>> + (void) strcpy(t,argv[0]);
>
>
> I believe that argc is guaranteed to be positive, so the "if(argc > 0)" test
> is redundant.
Corrected and return t[0] in order to be sure to keep strcpy.
> --
> Jakub Wilk
>
>
> --
> To UNSUBSCRIBE, email to debian-lint-maint-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact
> listmaster@lists.debian.org
> Archive: [🔎] 20150803203351.GA6601@jwilk.net">https://lists.debian.org/[🔎] 20150803203351.GA6601@jwilk.net
>
Reply to: