[lintian] 04/04: Closes serious bug and improve test
This is an automated email from the git hooks/post-receive script.
broucaries-guest pushed a commit to branch master
in repository lintian.
commit 02389b1e7d24f2ef632ac790557eb2137d912922
Author: Bastien ROUCARIÈS <roucaries.bastien+debian@gmail.com>
Date: Mon Aug 3 22:46:02 2015 +0200
Closes serious bug and improve test
return strcpy result in order to avoid code deletion by optimizer
Signed-off-by: Bastien ROUCARIÈS <roucaries.bastien+debian@gmail.com>
---
debian/changelog | 4 ++--
t/tests/binaries-general/debian/basic.c | 8 +++-----
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index 1e85f4e..4edc272 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,4 @@
-lintian (2.5.35) UNRELEASED; urgency=medium
+lintian (2.5.35) unstable; urgency=medium
* Summary of tag changes:
+ Added:
@@ -60,7 +60,7 @@ lintian (2.5.35) UNRELEASED; urgency=medium
* t/tests/binaries-general/*:
+ [BR] Fix a test suite failure with gcc5 by using compat 9, and
removing gets() that does not exist with C11 (used by default
- by gcc5).
+ by gcc5). (Closes: #794505).
-- Niels Thykier <niels@thykier.net> Wed, 22 Jul 2015 22:48:07 +0200
diff --git a/t/tests/binaries-general/debian/basic.c b/t/tests/binaries-general/debian/basic.c
index 5d03d86..3618004 100644
--- a/t/tests/binaries-general/debian/basic.c
+++ b/t/tests/binaries-general/debian/basic.c
@@ -6,9 +6,7 @@ main(int argc, char *argv[])
{
char t[10];
printf("Hello world!\n");
- /* Bad choice for reading from a security point of view, but it forces a stack
- protector, so meh.
- */
- if(argc > 0)
- (void) strcpy(t,argv[0]);
+ /* forces a stack protector */
+ (void) strcpy(t,argv[0]);
+ return (int) t[0];
}
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: