--- Begin Message ---
Source: lintian
Source-Version: 2.5.33
Severity: wishlist
Tags: patch
Hi!
The problem with LFS is actually worse than it seemed. because even
programs that might not need or usually have to read and handle large
files, might still fail, if they have to operate on files with large
metadata values, like inode numbers for example. A simple stat(2) on
a file might fail on a filesystem with large inode numbers, even if
the file is otherwise not large.
Here's a patch trying to clarify the above (but I'm not sure if I've
been too subtle?), and adding a mention to getconf for build systems
that do not use autoconf.
Thanks,
Guillem
From b3b82ea5d983080397476ddc52b7ad2441bd1a3f Mon Sep 17 00:00:00 2001
From: Guillem Jover <guillem@debian.org>
Date: Sun, 12 Jul 2015 13:14:30 +0200
Subject: [PATCH] c/binaries: Improve LFS tag description
Clarify that this does not only affect large files, but also large
metadata in general, like large inode numbers. And mention that the
getconf program can be used to retrieve system specific flags to
enable LFS.
---
checks/binaries.desc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/checks/binaries.desc b/checks/binaries.desc
index 33d07c2..db99863 100644
--- a/checks/binaries.desc
+++ b/checks/binaries.desc
@@ -385,14 +385,16 @@ Certainty: possible
Experimental: yes
Info: The listed ELF binary appears to be (partially) built without
"Large File Support" (LFS). If so, it may not be able to handle large
- files correctly.
+ files or files with large metadata values (ex: inode numbers) correctly.
.
To support large files, code review might be needed to make sure that
those files are not slurped into memory or mmap(2)ed, and that correct
64-bit data types are used (ex: off_t instead of ssize_t), etc. Once
that has been done ensure <tt>_FILE_OFFSET_BITS</tt> is defined and
set to 64 before the relevant files are included. This can be done by
- using the <tt>AC_SYS_LARGEFILE</tt> macro with autoconf.
+ using the <tt>AC_SYS_LARGEFILE</tt> macro with autoconf, or by appending
+ the output of <tt>getconf LFS_CFLAGS</tt> and <tt>getconf LFS_LDFLAGS</tt>
+ to <tt>CFLAGS</tt> and <tt>LDFLAGS</tt> respectively.
.
Take into account that even if this tag is not emitted, that does not
mean the binary is LFS-safe (ie. no OOM conditions, file truncation
--
2.4.3.573.g4eafbef
--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.5.34
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 792167@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 22 Jul 2015 21:55:58 +0200
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.34
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
lintian - Debian package checker
Closes: 715035 792167 792237 792501 793068
Changes:
lintian (2.5.34) unstable; urgency=medium
.
* Summary of tag changes:
+ Added:
- unstripped-static-library
.
* checks/binaries.{desc,pm}:
+ [NT] Apply patch from Guillem Jover to improve the tag
description of the LFS tag. (Closes: #792167)
+ [NT] Detect unstripped static libraries (as an
experimental tag).
* checks/cruft.pm:
+ [NT] Avoid svn-conflict-file tag for ".r0" files, since
there cannot be a conflict involving revision 0.
Thanks to Andreas Beckmann for the report.
(Closes: #793068)
+ [BR] Detect pdf, ps, and eps lenna file.
* checks/files.{desc,pm}:
+ [BR] Fix detection of sources.list file. (Closes: #792237)
* checks/systemd.pm:
+ [NT] Apply patches from Felipe Sateler to ignore known
masked init.d scripts. (Closes: #792501)
.
* commands/info -> info.pm:
+ [NT] Renamed info to info.pm to remove some boilerplate
code.
+ [NT] Forbid late --user-dirs and --include-dir options.
.
* frontend/lintian:
+ [NT] Forbid late --user-dirs and --include-dir options.
+ [NT] Remove the following obsolete command line
options: --root, --all, --binary, --source, --udeb.
They are no longer useful.
.
* lib/Lintian/Collect{,/*}.pm:
+ [NT] Add a shared memory cache that can be used to
reduce memory comsumption a bit for sharable objects.
(Closes: #715035)
* lib/Lintian/Data.pm:
+ [NT] Remove references to LINTIAN_ROOT as Lintian::Data
no longer uses it.
* lib/Lintian/Path.pm:
+ [NT] Rework some implementation details to reduce memory
consumption slightly.
+ [NT] The undocumented "type" and "time" methods have been
removed from the API.
+ [NT] The "uid" and "gid" methods now return 0 rather than
undef when numeric ownership is not collected.
.
* reporting/templates:
+ [NT] Remove (uses of) the "invisible-anchor" css class as
invisible (display: none) elements cannot be used as
anchors.
Checksums-Sha1:
491fcb7d7bbd7f06e3e3979080fce97c24d770eb 2731 lintian_2.5.34.dsc
b09752870cd488407f2e89ad3b50586cf8e8bd78 1220984 lintian_2.5.34.tar.xz
896995e5227c750702ee96075ba36a3548211040 819008 lintian_2.5.34_all.deb
Checksums-Sha256:
f5aee181b48017eefe5382b272eefa840cbbba617133ae8053b48d250c8e8ed7 2731 lintian_2.5.34.dsc
590d7c8c4457e4c76e23daafdd5e518d00d56aab5efb6220e818f764462e2678 1220984 lintian_2.5.34.tar.xz
40712986199ffc4a9e3d493cbfa6d00f74195bbee762c231191aaf46d2c10290 819008 lintian_2.5.34_all.deb
Files:
b964bbcab97bb435b6b36263f34bc3c8 2731 devel optional lintian_2.5.34.dsc
75301e71130477d2eb6b9caf8ab56a4b 1220984 devel optional lintian_2.5.34.tar.xz
a1deabae89110bc2c31987cbcce44c42 819008 devel optional lintian_2.5.34_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJVr/m2AAoJEAVLu599gGRCPbkQAKS4vvGSsSs5cRajjrSugQyo
Eqf1088LhFW91fulZCZA04CHFZB6YQrsEMk/119sueaf76STbUovifF9Vx/TOgr1
8C+Ohub84Q9QGyGZP2uk8HyPwaSokoWdHkTTBhQNmbSKE/l3S1JEjd5pH3yOjqMg
+hMTjfWQySNQcnRD5FXZr5HGLNZY6TomCOWcQSZZrhFuCY85m8Z33VT5f5anKfx9
1FmHQQpSS75nv0aH52FukZQYrbiUpJi1LEK1wCD+0dVveCaDeQRGqm1mBT/BTGVJ
hkiaFBd2e3PtCZ7AKiuumn/eQjnw5iSQAtI5/Dvl7K1B/cb6v1HlHTsEnY0xg+JK
l0NdX3dfS6myT/L1mvJVupG6qJ6pzBvCkvtTVuSJiyQHYiIe9l9/ptumpnughzZj
rDqBeErAGE9iERE862zzwtIDxVaf6Fs7TSdOKz778QeNY0sTC1r5dRu/Y2Wxx1Bw
6ky/0VB7RQc03HcsajxNaAnalDl9c4mvpgRvlnWP2NqTwgtNT/yhtjeUHidUH3m6
mdRcONUtQ30BXrvPv5s+yMyE3Bj+l0APqlSdA5Kr9cgo6K5ykoBJF28c7SBdmyZU
F6ImaaeRSHWg4IGjNOZHCt/Z68/gnQXI5l1lnym8nnBkuffcBMpVxK1A/vLtMOLr
YkKF4sUL7jsKwuiMe+Ea
=IsKl
-----END PGP SIGNATURE-----
--- End Message ---