[lintian] 01/01: binaries: limit LFS symbol checks to unresolved symbols
This is an automated email from the git hooks/post-receive script.
nthykier pushed a commit to branch master
in repository lintian.
commit 222cbfa321257d759c694fabcb930f0032b509e3
Author: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Date: Wed Jul 22 13:06:28 2015 +0200
binaries: limit LFS symbol checks to unresolved symbols
Guillem reported in BTS [0] that inetutils-ftpd is marked as
binary-file-built-without-LFS-support while it has LFS support. The
false-positive comes from a local symbol.
This patch limits the symbol checks to symbols which are unresolved
(i.e. not local, come from an external library) as suggested by Guillem.
Another (additional) limitation could be to limit the version to ^GLIBC_
as all the symbols for the LFS check come from GLIBC.
With this patch the inetutils-ftpd package is no longer marked with
binary-file-built-without-LFS-support while the havp package is still
marked.
[0] https://bugs.debian.org/787853
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Signed-off-by: Niels Thykier <niels@thykier.net>
---
checks/binaries.pm | 5 +++--
debian/changelog | 7 +++++++
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/checks/binaries.pm b/checks/binaries.pm
index 4b068dc..94197b6 100644
--- a/checks/binaries.pm
+++ b/checks/binaries.pm
@@ -152,9 +152,10 @@ sub run {
my ($foo, $sec, $sym) = @{$symbol};
unless (defined $has_lfs) {
- if ($LFS_SYMBOLS->known($sym)) {
+ if ($foo eq 'UND' and $LFS_SYMBOLS->known($sym)) {
# Using a 32bit only interface call, some parts of the
- # binary are built without LFS.
+ # binary are built without LFS. If the symbol is defined
+ # within the binary then we ignore it
$has_lfs = 0;
}
}
diff --git a/debian/changelog b/debian/changelog
index 1c1e822..58ac0ac 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,13 @@ lintian (2.5.35) UNRELEASED; urgency=medium
XXX: generate tag summary
+ * checks/binaries.pm:
+ + [NT] Apply patch from Sebastian Andrzej Siewior to inhibit
+ binary-file-built-without-LFS-support tags for binaries
+ that contains the "offending" LFS symbol. These tend to
+ come from gnulib and be LFS compliant. Thanks to Guillem
+ Jover for the report. (Closes: #787853)
+
* private/refresh-manual-refs:
+ [JW] Update the list of required packages.
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: