[lintian] 01/01: c/binaries: Improve LFS tag description
This is an automated email from the git hooks/post-receive script.
nthykier pushed a commit to branch master
in repository lintian.
commit 32e572b649a6946876bc87037c58b9fd8973e420
Author: Guillem Jover <guillem@debian.org>
Date: Sun Jul 12 13:14:30 2015 +0200
c/binaries: Improve LFS tag description
Clarify that this does not only affect large files, but also large
metadata in general, like large inode numbers. And mention that the
getconf program can be used to retrieve system specific flags to
enable LFS.
Signed-off-by: Niels Thykier <niels@thykier.net>
---
checks/binaries.desc | 6 ++++--
debian/changelog | 4 ++++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/checks/binaries.desc b/checks/binaries.desc
index 33d07c2..db99863 100644
--- a/checks/binaries.desc
+++ b/checks/binaries.desc
@@ -385,14 +385,16 @@ Certainty: possible
Experimental: yes
Info: The listed ELF binary appears to be (partially) built without
"Large File Support" (LFS). If so, it may not be able to handle large
- files correctly.
+ files or files with large metadata values (ex: inode numbers) correctly.
.
To support large files, code review might be needed to make sure that
those files are not slurped into memory or mmap(2)ed, and that correct
64-bit data types are used (ex: off_t instead of ssize_t), etc. Once
that has been done ensure <tt>_FILE_OFFSET_BITS</tt> is defined and
set to 64 before the relevant files are included. This can be done by
- using the <tt>AC_SYS_LARGEFILE</tt> macro with autoconf.
+ using the <tt>AC_SYS_LARGEFILE</tt> macro with autoconf, or by appending
+ the output of <tt>getconf LFS_CFLAGS</tt> and <tt>getconf LFS_LDFLAGS</tt>
+ to <tt>CFLAGS</tt> and <tt>LDFLAGS</tt> respectively.
.
Take into account that even if this tag is not emitted, that does not
mean the binary is LFS-safe (ie. no OOM conditions, file truncation
diff --git a/debian/changelog b/debian/changelog
index f8b7cd9..8ffeed2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,10 @@ lintian (2.5.34) UNRELEASED; urgency=medium
XXX: generate tag summary
+ * checks/binaries.desc:
+ + [NT] Apply patch from Guillem Jover to improve the tag
+ description of the LFS tag. (Closes: #792167)
+
* commands/info -> info.pm:
+ [NT] Renamed info to info.pm to remove some boilerplate
code.
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: