[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/02: r/html_reports: Merge open+binmode into open calls



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit c015fb76b6b9bc1a5251f85eaf690548b2e0db5b
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Jul 5 08:31:00 2015 +0200

    r/html_reports: Merge open+binmode into open calls
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 reporting/html_reports | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/reporting/html_reports b/reporting/html_reports
index 886c699..231a64e 100755
--- a/reporting/html_reports
+++ b/reporting/html_reports
@@ -95,8 +95,7 @@ for my $template (
     qw/head foot clean index maintainer maintainers packages tag
     tags tags-severity tag-not-seen tags-all/
   ) {
-    open(my $fd, '<', "$TEMPLATES/$template.tmpl");
-    binmode($fd, ':encoding(UTF-8)');
+    open(my $fd, '<:encoding(UTF-8)', "$TEMPLATES/$template.tmpl");
     my %options = (TYPE => 'FILEHANDLE', SOURCE => $fd);
     $templates{$template} = Text::Template->new(%options)
       or die "cannot load template $template: $Text::Template::ERROR\n";
@@ -104,8 +103,7 @@ for my $template (
 }
 
 {
-    open(my $fd, '<', "$TEMPLATES/lintian.css.tmpl");
-    binmode($fd, ':encoding(UTF-8)');
+    open(my $fd, '<:encoding(UTF-8)', "$TEMPLATES/lintian.css.tmpl");
     $templates{'lintian.css'} = Text::Template->new(
         TYPE => 'FILEHANDLE',
         SOURCE => $fd,
@@ -933,8 +931,7 @@ sub output_template {
                 %{$data},
             }) or die "Filling out footer of $file: $Text::Template::ERROR\n";
     };
-    open(my $fd, '>', "$HTML_TMP_DIR/$file");
-    binmode($fd, ':encoding(UTF-8)');
+    open(my $fd, '>:encoding(UTF-8)', "$HTML_TMP_DIR/$file");
     $template->fill_in(OUTPUT => $fd, HASH => $data)
       or die "filling out $file failed: $Text::Template::ERROR\n";
     close($fd);

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: