[lintian] 01/01: Change tag name to trailing-slash-for-dpkg-maintscript-helper-symlink_to_dir
This is an automated email from the git hooks/post-receive script.
broucaries-guest pushed a commit to branch master
in repository lintian.
commit b52daac1ac49b4f91851c66f4811935f95a3a642
Author: bastien <roucaries.bastien+debian@gmail.com>
Date: Fri Jul 3 20:12:56 2015 +0200
Change tag name to trailing-slash-for-dpkg-maintscript-helper-symlink_to_dir
---
checks/scripts.desc | 9 ++++-----
data/scripts/maintainer-script-bad-command | 2 +-
t/scripts/implemented-tags.t | 1 +
t/tests/scripts-maintainer-general/tags | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/checks/scripts.desc b/checks/scripts.desc
index 3454e3f..da34b6d 100644
--- a/checks/scripts.desc
+++ b/checks/scripts.desc
@@ -368,13 +368,12 @@ Info: The maintainer script seems to call <tt>start-stop-daemon</tt>
scripts.
Ref: policy 9.3.3.2
-Tag: maintainer-script-should-not-use-slash-for-dpkg-maintscript-helper-symlink_to_dir
+Tag: trailing-slash-for-dpkg-maintscript-helper-symlink_to_dir
Severity: serious
Certainty: certain
-Info: The maintainer script seems to call <tt>start-stop-daemon</tt>
- directly. Long-running daemons should be started and stopped via init
- scripts using <tt>invoke-rc.d</tt> rather than directly in maintainer
- scripts.
+Info: The maintainer script seems to call dpkg-maintscript-helper
+ symlink_to_dir with a trailling slash for pathname. This render package
+ uninstallable.
Ref: dpkg-maintscript-helper (1)
Tag: maintainer-script-removes-device-files
diff --git a/data/scripts/maintainer-script-bad-command b/data/scripts/maintainer-script-bad-command
index 174979e..efd3168 100644
--- a/data/scripts/maintainer-script-bad-command
+++ b/data/scripts/maintainer-script-bad-command
@@ -41,7 +41,7 @@ maintainer-script-should-not-use-service ~~ 1 ~~
maintainer-script-should-not-use-start-stop-daemon ~~ 0 ~~ ~~ ~~\bstart-stop-daemon(?=\s)(?!.*\s--stop\b)
maintainer-script-should-not-use-update-alternatives-remove ~~ 1 ~~ ~~^postrm$ ~~\b update\-alternatives\s+\-\-remove\b
maintainer-script-should-not-use-update-alternatives-set ~~ 1 ~~ ~~ ~~^(?!\s*echo\s+["'][^'"]*)\bupdate\-alternatives\s+\-\-(?:set|set\-selections|config)\b
-maintainer-script-should-not-use-slash-for-dpkg-maintscript-helper-symlink_to_dir ~~ 1 ~~ ~~ ~~ dpkg-maintscript-helper\s+symlink_to_dir\s+[^\s]+/\s
+trailing-slash-for-dpkg-maintscript-helper-symlink_to_dir ~~ 1 ~~ ~~ ~~ dpkg-maintscript-helper\s+symlink_to_dir\s+[^\s]+/\s
# sendmail use override do not change it now
suidregister-used-in-maintainer-script ~~ 1 ~~ ~~ ~~\bsuidregister\b
diff --git a/t/scripts/implemented-tags.t b/t/scripts/implemented-tags.t
index a08baf3..aaed590 100755
--- a/t/scripts/implemented-tags.t
+++ b/t/scripts/implemented-tags.t
@@ -64,6 +64,7 @@ our $EXCLUDE =join(
^source-contains-autogenerated-.*$
^source-contains-data-.*$
^invalid-short-name-in-dep5-copyright$
+ ^trailing-slash-for-dpkg-maintscript-helper-symlink_to_dir$
));
# Exclude "lintian.desc" as it does not have a perl module like other
diff --git a/t/tests/scripts-maintainer-general/tags b/t/tests/scripts-maintainer-general/tags
index 4e046f7..77c15b7 100644
--- a/t/tests/scripts-maintainer-general/tags
+++ b/t/tests/scripts-maintainer-general/tags
@@ -12,11 +12,11 @@ E: scripts-maintainer-general: maintainer-script-should-not-use-adduser-system-w
E: scripts-maintainer-general: maintainer-script-should-not-use-dpkg-status-directly postinst:56
E: scripts-maintainer-general: maintainer-script-should-not-use-install-sgmlcatalog postinst:74
E: scripts-maintainer-general: maintainer-script-should-not-use-install-sgmlcatalog postinst:75
-E: scripts-maintainer-general: maintainer-script-should-not-use-slash-for-dpkg-maintscript-helper-symlink_to_dir postinst:188
E: scripts-maintainer-general: maintainer-shell-script-fails-syntax-check prerm
E: scripts-maintainer-general: mknod-in-maintainer-script postinst:125
E: scripts-maintainer-general: read-in-maintainer-script postinst:10
E: scripts-maintainer-general: suidregister-used-in-maintainer-script postinst:101
+E: scripts-maintainer-general: trailing-slash-for-dpkg-maintscript-helper-symlink_to_dir postinst:188
W: scripts-maintainer-general: command-with-path-in-maintainer-script postinst:117 /usr/bin/foo
W: scripts-maintainer-general: command-with-path-in-maintainer-script postinst:118 /usr/bin/foo
W: scripts-maintainer-general: command-with-path-in-maintainer-script postinst:153 /usr/bin/gconftool-2
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: