[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 05/05: c/binaries: Avoid looking up objdump_info twice for ELF files



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 0fcfdbb31c78ce85fb480a18c4b7341f795c7b31
Author: Niels Thykier <niels@thykier.net>
Date:   Fri Jul 3 18:44:40 2015 +0200

    c/binaries: Avoid looking up objdump_info twice for ELF files
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 checks/binaries.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/checks/binaries.pm b/checks/binaries.pm
index f2607fc..dbf0e98 100644
--- a/checks/binaries.pm
+++ b/checks/binaries.pm
@@ -274,8 +274,6 @@ sub run {
           unless ($fileinfo =~ m/^[^,]*\bELF\b/)
           or ($fileinfo =~ m/\bcurrent ar archive\b/);
 
-        $objdump = $info->objdump_info->{$file};
-
         # Warn about Architecture: all packages that contain shared libraries.
         if ($arch eq 'all') {
             tag 'arch-independent-package-contains-binary-or-object',$file;
@@ -302,6 +300,8 @@ sub run {
             # unneeded sections in those.
             next if $file =~ m/_g\.a$/;
 
+            $objdump = $info->objdump_info->{$file};
+
             foreach my $obj (@{ $objdump->{'objects'} }) {
                 my $libobj = $info->objdump_info->{"${file}(${obj})"};
                 # Shouldn't happen, but...

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: