[lintian] 01/01: Detect double comma in uploader field
This is an automated email from the git hooks/post-receive script.
broucaries-guest pushed a commit to branch master
in repository lintian.
commit 7491d8883188c49799cc9386ae4788977fa9c864
Author: bastien <roucaries.bastien+debian@gmail.com>
Date: Sun Jun 14 23:44:58 2015 +0200
Detect double comma in uploader field
Signed-off-by: bastien <roucaries.bastien+debian@gmail.com>
---
checks/fields.pm | 6 ++++++
debian/changelog | 3 +++
t/tests/fields-maintainer-general/debian/debian/control.in | 1 +
t/tests/fields-maintainer-general/tags | 1 +
4 files changed, 11 insertions(+)
diff --git a/checks/fields.pm b/checks/fields.pm
index e54df82..815440f 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -435,6 +435,12 @@ sub run {
unfold($f, \$maintainer);
if ($f eq 'uploaders') {
+ # check for empty field see #783628
+ if($maintainer =~ m/,\s*,/) {
+ tag 'uploader-name-missing',
+ 'you have used a double comma';
+ $maintainer =~ s/,\s*,/,/g;
+ }
my %duplicate_uploaders;
my @uploaders = map { split /\@\S+\K\s*,\s*/ }
split />\K\s*,\s*/, $maintainer;
diff --git a/debian/changelog b/debian/changelog
index b3a92da..6d41874 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -15,6 +15,9 @@ lintian (2.5.32) UNRELEASED; urgency=medium
* checks/debhelper.{desc,pm}:
+ [NT] Warn about using dh --{until,before,after,remaining} as
these are deprecated and have been since debhelper/8.9.4.
+ * checks/fields.pm:
+ + [BR] Detect double comma in uploaders fields.
+ (Closes: #783628).
* checks/files.pm:
+ [NT] Apply patch from Tomasz Buchert to avoid false-positive
package-contains-timestamped-gzip in some cases.
diff --git a/t/tests/fields-maintainer-general/debian/debian/control.in b/t/tests/fields-maintainer-general/debian/debian/control.in
index 255e9ea..2529636 100644
--- a/t/tests/fields-maintainer-general/debian/debian/control.in
+++ b/t/tests/fields-maintainer-general/debian/debian/control.in
@@ -5,6 +5,7 @@ Maintainer: <lintian-maint@debian.org>
Uploaders: <lintian-maint@debian.org>, Russ Allbery <rra@debian.org>,
Russ Allbery <rra@debian.org>,
I L. Oop <fields-maintainer-general@packages.qa.debian.org>,
+ Double comma <double@comma.com>, ,
Mr. Missing Comma <mrmc@comma.com>
Mrs. Missing Comma <mrsmc@comma.com>
Standards-Version: {$standards_version}
diff --git a/t/tests/fields-maintainer-general/tags b/t/tests/fields-maintainer-general/tags
index 3eb787c..1fa5999 100644
--- a/t/tests/fields-maintainer-general/tags
+++ b/t/tests/fields-maintainer-general/tags
@@ -2,6 +2,7 @@ E: fields-maintainer-general source: maintainer-name-missing <lintian-maint@debi
E: fields-maintainer-general source: uploader-address-causes-mail-loops-or-bounces I L. Oop <fields-maintainer-general@packages.qa.debian.org>
E: fields-maintainer-general source: uploader-address-malformed Mr. Missing Comma <mrmc@comma.com> Mrs. Missing Comma <mrsmc@comma.com>
E: fields-maintainer-general source: uploader-name-missing <lintian-maint@debian.org>
+E: fields-maintainer-general source: uploader-name-missing you have used a double comma
E: fields-maintainer-general: maintainer-name-missing <lintian-maint@debian.org>
W: fields-maintainer-general source: changelog-should-mention-nmu
W: fields-maintainer-general source: duplicate-uploader Russ Allbery <rra@debian.org>
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: