[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#802028: Bug #802028: Line length is not a good indicator for javascript files being not in preferred way of modification: same here



Hi,

I can confirm this bug.  Running lintian on to be uploaded moodle
(2.7.11+dfsg-1) (sources available from
https://download.moodle.org/releases/security/ , likely moodle (2.7.10+dfsg-1)
which is in sid now will give similar results) gives

E: moodle source: source-is-missing mod/forum/forum.js
E: moodle source: source-is-missing mod/imscp/module.js
E: moodle source: source-is-missing lib/jquery/ui-1.10.4/jquery-ui.js
E: moodle source: source-is-missing lib/yui/build/moodle-core-dock/moodle-core-dock-debug.js
E: moodle source: source-is-missing lib/yuilib/3.15.0/event-valuechange/event-valuechange-debug.js
E: moodle source: source-is-missing grade/grading/form/rubric/js/rubriceditor.js
E: moodle source: source-is-missing lib/yui/src/dock/js/dock.js
E: moodle source: source-is-missing lib/editor/tinymce/plugins/spellchecker/tinymce/editor_plugin.js
E: moodle source: source-is-missing lib/yuilib/2in3/2.9.0/build/yui2-animation/yui2-animation-debug.js
E: moodle source: source-is-missing lib/yuilib/2in3/2.9.0/build/yui2-container/yui2-container-debug.js

P: moodle source: source-contains-prebuilt-javascript-object mod/forum/forum.js line length is 175 characters (>128)
P: moodle source: source-contains-prebuilt-javascript-object mod/imscp/module.js line length is 147 characters (>128)
P: moodle source: source-contains-prebuilt-javascript-object lib/jquery/ui-1.10.4/jquery-ui.js line length is 840 characters (>512)
P: moodle source: source-contains-prebuilt-javascript-object lib/yui/build/moodle-core-dock/moodle-core-dock-debug.js line length is 150 characters (>128)
P: moodle source: source-contains-prebuilt-javascript-object lib/yuilib/3.15.0/event-valuechange/event-valuechange-debug.js line length is 144 characters (>128)
P: moodle source: source-contains-prebuilt-javascript-object grade/grading/form/rubric/js/rubriceditor.js line length is 157 characters (>128)
P: moodle source: source-contains-prebuilt-javascript-object lib/yui/src/dock/js/dock.js line length is 150 characters (>128)
P: moodle source: source-contains-prebuilt-javascript-object lib/editor/tinymce/plugins/spellchecker/tinymce/editor_plugin.js line length is 179 characters (>128)
P: moodle source: source-contains-prebuilt-javascript-object lib/yuilib/2in3/2.9.0/build/yui2-animation/yui2-animation-debug.js line length is 754 characters (>512)
P: moodle source: source-contains-prebuilt-javascript-object lib/yuilib/2in3/2.9.0/build/yui2-container/yui2-container-debug.js line length is 137 characters (>128)

I've checked all these files manually, looks like genuine sources to me.

Indeed, as suggested, changing

 # constant for insane line length
 use constant INSANE_LINE_LENGTH => 512;
 use constant SAFE_LINE_LENGTH => 128;

in lintian/checks/cruft.pm to some less strict values looks like the way to go
here.

Thanks, Bye,

Joost

-- 
Joost van Baal-Ilić                       http://abramowitz.uvt.nl/
                                                 Tilburg University
mailto:joostvb.uvt.nl                               The Netherlands

Attachment: signature.asc
Description: Digital signature


Reply to: