Bug#801482: The name of a programme, from which an error message comes, is missing in the lintian's message
Control: severity -1 minor
Control: tags -1 + patch
Severity: important
This is definitely not "a bug which has a major effect on the usability
of a package".
* Bjarni Ingi Gislason <bjarniig@rhi.hi.is>, 2015-10-11, 00:41:
W: lintian: manpage-has-errors-from-man usr/share/man/man1/lintian-info.1.gz line 5: TMPDIR: unbound variable
W: lintian: manpage-has-errors-from-man usr/share/man/man1/lintian.1.gz line 5: TMPDIR: unbound variable
* What outcome did you expect instead?
The name of the programme where the error occurred.
Well, the tag name says "errors-from-man" and the error occurred in man,
so everything is clear.
This is important to reduce the time figuring out from where it came.
Can you think of a more realistic scenario where the user would be
genuinely confused about origin of the captured error?
Anyway, the attached patch seems to address you concerns. When it's
applied, you get:
W: lintian: manpage-has-errors-from-man usr/share/man/man1/lintian-info.1.gz /path/to/man: line 5: TMPDIR: unbound variable
W: lintian: manpage-has-errors-from-man usr/share/man/man1/lintian.1.gz /path/to/man: line 5: TMPDIR: unbound variable
Hopefully the patch doesn't break anything else.
How will (the cause of) this programming error be documented, so people
(can) learn from it and do not repeat it themselves?
As usually, in the bug log and in the changelog. (But this condescending
tone is not helpful...)
--
Jakub Wilk
diff --git a/checks/manpages.pm b/checks/manpages.pm
--- a/checks/manpages.pm
+++ b/checks/manpages.pm
@@ -401,7 +401,7 @@
# ignore common undefined macros from pod2man << Perl 5.10
next if /warning: (?:macro )?\`(?:Tr|IX)\' not defined/;
chomp;
- s/^[^:]+://o;
+ s/^\Q<standard input>://o;
tag 'manpage-has-errors-from-man', $file, $_;
last;
}
Reply to: