[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#790932: lintian: Test for UPX compression of binaries does not work



Control: tags -1 patch

On 2015-07-03 08:55, Niels Thykier wrote:
> Package: lintian
> Version: 2.5.32
> Severity: normal
> 
> $ apt-get instal upx
> $ upx -9 /bin/ls -o test
> $ LINTIAN_ROOT=. perl -I. helpers/coll/objdump-info-helper test | \
>     grep -i upx
> 
> If it worked, the last line should say "UPX: yes".
> 
> It seems that our "head $binary | grep -q 'packed.*with.*UPX'" is no
> longer suffient.  At the same time, it takes a considerable time to
> execute that pipeline.  On 500 ELF files from
> linux-image-4.0.0-2-amd64, it consumes 3 out of 4.5 seconds.
> 
> I am split between fixing the code (making it use "strings" and
> running it in a check) vs just dropping it, given it hasn't worked for
> at least 2 years (and likely more).
> 
> ~Niels
> 
> 

Patch removing the check and related code attached.  Given no
objections, I will apply it to master within 2 days.

Thanks,
~Niels


Attachment: drop-upx.diff
Description: application/mbox


Reply to: