[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#783815: lintian: Using oracle java 8 in a package generate unknow-java-class-version.



Control: reopen -1

Hi again,

Axel Beckert wrote:
> Version: 2.5.23
[...]
> Jonathan Plamondon wrote:
> > Package: lintian
> > Version: 2.5.10.4
> [...]
> >    * What led up to the situation?
> > 	We have a package using java 8
> >    * What exactly did you do (or not do) that was effective (or
> >      ineffective)?
> > 	The warning are anoying. 
> >    * What was the outcome of this action?
> > 	The warning are anoying
> >    * What outcome did you expect instead?
> > 	No warning.
[...]
> Besides that this issue already has been fixed fixed in Lintian since
> version 2.5.23 of June 2014 and the fix is included in Debian's
> current stable release.

I may have been to quick with closing this. The code introduced in
2.5.23 may have an off-by-one error, but it also may be on purpose
(the changelog entry sys "Catch uses of Java8 byte code"):

            if (   $mver <= $MAX_BYTECODE->value('min-bytecode-version') - 1
                or $mver
                >= $MAX_BYTECODE->value('max-bytecode-existing-version')) {
                # First public major version was 45 (Java1), latest
                # version is 52 (Java8).
                tag 'unknown-java-class-version', $jar_file,
                  "($class -> $mver)";

The ">=" in there likely should be just a ">" if Java 8 byte code
(i.e. for use with openjdk-8 from experimental) is fine. Or am I
misunderstanding the semantics of max-bytecode-existing-version?

Sylvestre: It'd be nice if you could have a look at this as you
introduced that code path in be04767b998558e2fbc637ddee45f675141e13ee.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE


Reply to: