Bug#757551: lintian: check if DEP-5 debian/copyright covers all files in the unpacked sources

[Niels Thykier <niels@thykier.net>]

On 2014-08-10 12:48, Johannes Schauer wrote:
> Quoting Niels Thykier (2014-08-10 12:17:55)
>> Okay, what about other valid special regex characters? Like the following
>> (hopefully rare) file names
>>
>>  * file-with-(something-in-parenthesis).png
>>  * or-perhaps-only-one-{-which-causes-a-compile-failure.png
>>  * even-]-is-not-safe.png
>>  * Perhaps-even-|-will-cause-problems.png
>>  * Lets-not-forget-^-and-$-for-added-fun.png
>>
>> :)
> 
> Okay, I get you: more tests :D You'll find them in the attached patch.
> 
> While the examples you gave passed without changes as expected, I found another
> problem accidentally. Since $info->sorted_index contains not only files but
> also directories, the former versions of this patch also required that
> debian/copyright specified the copyright for directories. This is probably not
> necessary so I only retrieve those items without a trailing slash from
> $info->sorted_index now.
> 
> cheers, josch
> 

Ah, I see now that I misread the code.  The non-pattern parts will hit
the quotemeta case ($3) rather than being passed through ($4).  My mistake.

Having tested it there are only two minor issues:
 * It needs perltidy'ing
 * Two other source-copyright tests needs updating
   - source-copyright-empty-field
   - source-copyright-undefined

~Niels