[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#731340: lintian: [new check] Check if debian/upstream files are valid YAML



On 2013-12-04 14:04, Simon Kainz wrote:
> Package: lintian
> Version: 2.5.10.4
> Severity: wishlist
> Tags: patch
> 
> 
> After processing some debian/upstream whic hcontained broken/invalid YAML data,
> i created the following check together with tille@debian.org:
> 
> if debian/upstream is not avail ->      pedantic warning
> Invalid YAML ->                         "normal" warning
> YAML with invalid field ->                      "normal" warning
> 
> Please see my attached file.
> 
> Would be nice if this could be integrated into lintian.
> 
> [...]
> 

Hi Simon,

Thanks for taking the time to write a patch and sorry for the long delay
in getting back to you.
  We already commented on your patch a while ago, but unfortunately, you
were never added to the recipient list of those mails ...

Our primary concern with your patch is that it relies on "Test::YAML"
and "Test::More", which are modules only used for testing code (e.g.
build time tests).

Beyond that, there are two additional improvements worth considering:
 * Adding a test case for your new checks / tags
 * Moving the (contents of) "@allowed_fields" into a data file.

~Niels


Reply to: