[lintian] 01/01: c/cruft: Make check_missing_source a bit more concise

[Niels Thykier <nthykier@moszumanska.debian.org>]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 4168373a4aa4864b7cf43f1ebce9e4d587f2f5c1
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Mar 23 13:36:13 2014 +0100

    c/cruft: Make check_missing_source a bit more concise
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 checks/cruft.pm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/checks/cruft.pm b/checks/cruft.pm
index ced1f4c..1dfbacc 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -690,8 +690,6 @@ sub check_missing_source {
     my @replacementspair;
     if(defined($replacementspairref)) {
         @replacementspair = @{$replacementspairref};
-    }else {
-        @replacementspair = ();
     }
 
     unless ($file->is_regular_file) {
@@ -704,11 +702,10 @@ sub check_missing_source {
 
     # try to find for each replacement
   REPLACEMENT:
-    foreach my $pair (0..@replacementspair-1) {
+    foreach my $pair (@replacementspair) {
         my $newbasename = $basename;
 
-        my $match = $replacementspair[$pair][0];
-        my $replace = $replacementspair[$pair][1];
+        my ($match, $replace) = @{$pair};
 
         if($match eq '') {
             $newbasename = $basename;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git