[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/02: c/cruft.pm: Delay the "isjsfile" test a bit



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 431a7e1f5e063e07543506e2bbfcb64f41cbbd42
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Mar 23 08:09:19 2014 +0100

    c/cruft.pm: Delay the "isjsfile" test a bit
    
    There is no need perform the test on known "non-js" files.
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 checks/cruft.pm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/checks/cruft.pm b/checks/cruft.pm
index fd26fbe..6cfab49 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -761,12 +761,6 @@ sub check_missing_source {
 sub full_text_check {
     my ($entry, $info, $name, $path) = @_;
 
-    my $isjsfile = ($name =~ m/\.js/) ? 1 : 0;
-    if($isjsfile) {
-        my $minjsregexp =  _minified_javascript_name_regexp();
-        $isjsfile = ($name =~ m{$minjsregexp}) ? 0 : 1;
-    }
-
     # license string in debian/changelog are probably just change
     # Ignore these strings in d/README.{Debian,source}.  If they
     # appear there it is probably just "file XXX got removed
@@ -777,6 +771,12 @@ sub full_text_check {
         return;
     }
 
+    my $isjsfile = ($name =~ m/\.js/) ? 1 : 0;
+    if($isjsfile) {
+        my $minjsregexp =  _minified_javascript_name_regexp();
+        $isjsfile = ($name =~ m{$minjsregexp}) ? 0 : 1;
+    }
+
     open(my $fd, '<:raw', $path);
     # allow to check only text file
     unless (-T $fd) {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: