[lintian] 01/01: c/scripts: Optimise out some calls to L::Data->value

[Niels Thykier <nthykier@moszumanska.debian.org>]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit a7eed6c60d4467f12dc880e8e171d4a1ae3605f5
Author: Niels Thykier <niels@thykier.net>
Date:   Sat Mar 8 10:17:39 2014 +0100

    c/scripts: Optimise out some calls to L::Data->value
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 checks/scripts.pm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/checks/scripts.pm b/checks/scripts.pm
index 958f1d3..296b7f7 100644
--- a/checks/scripts.pm
+++ b/checks/scripts.pm
@@ -1092,16 +1092,18 @@ sub generic_check_bad_command {
     # try generic bad maintainer script command tagging
   BAD_CMD:
     foreach my $bad_cmd_tag ($BAD_MAINT_CMD->all) {
-        my $incat = $BAD_MAINT_CMD->value($bad_cmd_tag)->{'in_cat_string'};
-        my $inpackage = $BAD_MAINT_CMD->value($bad_cmd_tag)->{'in_package'};
-        my $inscript = $BAD_MAINT_CMD->value($bad_cmd_tag)->{'in_script'};
+        my $bad_cmd_data = $BAD_MAINT_CMD->value($bad_cmd_tag);
+        my $inscript = $bad_cmd_data->{'in_script'};
+        my $incat; 
         if ($file !~ m{$inscript}) {
             next BAD_CMD;
         }
+        $incat = $bad_cmd_data->{'in_cat_string'};
         if ($incat == $findincatstring) {
-            my $regex= $BAD_MAINT_CMD->value($bad_cmd_tag)->{'regexp'};
+            my $regex = $bad_cmd_data->{'regexp'};
             if ($line =~ m{$regex}) {
                 my $extrainfo = defined($1) ? "\'$1\'" : '';
+                my $inpackage = $bad_cmd_data->{'in_package'};
                 unless($pkg =~ m{$inpackage}) {
                     tag $bad_cmd_tag, "$file:$.", $extrainfo;
                 }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git