Bug#739671: phppear check randomly checks one binary
On 2014-03-06 08:32, Mathieu Parent wrote:
> 2014-02-22 18:42 GMT+01:00 Niels Thykier <niels@thykier.net>:
> [...]
>
> Hi,
>
> Thanks for your review.
>
>>>
>>> + $self->{binary_names} = ();
>>
>> I think you need to use "[]" instead of "()" here (to get a list ref)
>
> [...]
>>> + push $self->{binary_names}, $pkg;
>>
>> Likewise, you need "push(@{$self->{binary_names} }, $pkg);" here.
>>
>> Technically, I believe this one will work with "very recent" versions of
>> Perl (possibly as an experimental feature), but I doubt it works with
>> the version in stable.
>>
>>> }
>>> $self->{binary_field} = \%packages;
>>
>> Alternatively, I believe you can replace those two lines with:
>> $self->{binary_names} = \@control_data;
>
> I've implemented the first solution. See attachment.
>
> Regads
>
Merged into master as [1]. I took the liberty of updating the POD
documentation as well in [2].
Thanks for your work.
~Niels
[1]
http://anonscm.debian.org/gitweb/?p=lintian/lintian.git;a=commitdiff;h=aa9ea53e055ec79166ce838e81133a9bd271c26b
[2]
http://anonscm.debian.org/gitweb/?p=lintian/lintian.git;a=commitdiff;h=e6ec09ce55a6e5c872f8836b76725800b6784f2b
Reply to: