[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: L::SlidingWindow: Remove some redundant statements



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit c898c1449fa1080a972cbce01fd62981ce8def33
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Feb 16 15:07:40 2014 +0100

    L::SlidingWindow: Remove some redundant statements
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 lib/Lintian/SlidingWindow.pm | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/lib/Lintian/SlidingWindow.pm b/lib/Lintian/SlidingWindow.pm
index 0b6fc55..da66aca 100644
--- a/lib/Lintian/SlidingWindow.pm
+++ b/lib/Lintian/SlidingWindow.pm
@@ -48,7 +48,7 @@ sub new {
 
 sub readwindow {
     my ($self) = @_;
-    my $window;
+    my ($window, $queue);
     unless(read($self->{'_handle'}, $window, $self->{'_blocksize'})) {
         return;
     }
@@ -61,11 +61,10 @@ sub readwindow {
 
     $self->{'_blocknumber'}++;
 
-    my $block;
-    shift @{$self->{'_queue'}};
-    push(@{$self->{'_queue'}}, $window);
-    $block =  join '', @{$self->{'_queue'}};
-    return $block;
+    $queue = $self->{'_queue'};
+    shift(@{$queue});
+    push(@{$queue}, $window);
+    return join('', @{$queue});
 }
 
 sub blocknumber {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: