[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: FrontendUtil.pm: Don't clean HOME + XDG_* variables when sanitizing the environment



This is an automated email from the git hooks/post-receive script.

abe pushed a commit to branch master
in repository lintian.

commit 6a4039ccfd29be695ca7a434f5c4ae30dd6e38ae
Author: Axel Beckert <abe@deuxchevaux.org>
Date:   Sat Oct 25 16:35:44 2014 +0200

    FrontendUtil.pm: Don't clean HOME + XDG_* variables when sanitizing the environment
    
    Signed-off-by: Axel Beckert <abe@deuxchevaux.org>
---
 debian/changelog                     |  4 ++++
 lib/Lintian/Internal/FrontendUtil.pm | 14 +++++++++++++-
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 64fd5a9..6448577 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -15,6 +15,10 @@ lintian (2.5.30) UNRELEASED; urgency=medium
     + [NT] Apply patch from Johannes Schauer to fix FTBFS with
       newer dpkg that have stricter checking of build-profiles.
 
+  * lib/Lintian/Internal/FrontendUtil.pm:
+    + [AB] Don't clean HOME and some XDG_* variables when sanitizing the
+      environment. (Closes: #766737)
+
  -- Niels Thykier <niels@thykier.net>  Sat, 25 Oct 2014 13:20:50 +0200
 
 lintian (2.5.29) unstable; urgency=medium
diff --git a/lib/Lintian/Internal/FrontendUtil.pm b/lib/Lintian/Internal/FrontendUtil.pm
index 67aa052..3755404 100644
--- a/lib/Lintian/Internal/FrontendUtil.pm
+++ b/lib/Lintian/Internal/FrontendUtil.pm
@@ -53,7 +53,19 @@ sub check_test_feature{
     # variables.  This is mostly to ensure we know what state tools
     # (e.g. tar) start in.  In particular, we do not want to inherit
     # some random "TAR_OPTIONS" or "GZIP" values.
-    my %PRESERVE_ENV = map { $_ => 1 } qw(PATH TMPDIR LC_ALL LC_MESSAGES LANG);
+    my %PRESERVE_ENV = map { $_ => 1 } qw(
+      HOME
+      LANG
+      LC_ALL
+      LC_MESSAGES
+      PATH
+      TMPDIR
+      XDG_CACHE_HOME
+      XDG_CONFIG_DIRS
+      XDG_CONFIG_HOME
+      XDG_DATA_DIRS
+      XDG_DATA_HOME
+    );
 
     sub sanitize_environment {
         for my $key (keys(%ENV)) {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: