[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#766468: marked as done ([checks/nmu] canonicalize chops off ">")



Your message dated Fri, 24 Oct 2014 22:24:43 +0000
with message-id <E1XhnHn-0002RV-84@franck.debian.org>
and subject line Bug#766468: fixed in lintian 2.5.29
has caused the Debian Bug report #766468,
regarding [checks/nmu] canonicalize chops off ">"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
766468: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=766468
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.5.28
Severity: wishlist
Tags: patch

The canonicalize function is checks/nmu.pm chops off final ">" from the address. Although it doesn't seem to break anything in practice, it's a bit strange. I've attached patch to fix it.

--
Jakub Wilk
diff --git a/checks/nmu.pm b/checks/nmu.pm
--- a/checks/nmu.pm
+++ b/checks/nmu.pm
@@ -132,7 +132,7 @@
 # are case-insensitive in the right-hand side.
 sub canonicalize {
     my ($maintainer) = @_;
-    $maintainer =~ s/(<[^>\@]+\@)([\w.-]+)>/$1 . lc ($2)/e;
+    $maintainer =~ s/<([^>\@]+\@)([\w.-]+)>/<$1\L$2>/;
     return $maintainer;
 }
 

--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.5.29

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 766468@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 24 Oct 2014 23:15:52 +0200
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.29
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
 lintian    - Debian package checker
Closes: 762609 763773 765311 765995 766033 766468
Changes:
 lintian (2.5.29) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - dbus-policy-at-console
       - dbus-policy-without-send-destination
       - dbus-session-service-wrong-name
       - dbus-system-service-wrong-name
       - invalid-profile-name-in-build-profiles-field
       - invalid-profile-name-in-source-relation
       - invalid-restriction-formula-in-build-profiles-field
       - restriction-formula-with-debhelper-with-conflicting-version
       - restriction-formula-with-debhelper-without-debhelper-version
       - restriction-formula-with-versioned-dpkg-dev-conflict
       - restriction-formula-without-versioned-dpkg-dev-dependency
     + Removed:
       - invalid-restriction-label-in-source-relation
       - invalid-restriction-namespace-in-source-relation
       - invalid-restriction-term-in-source-relation
       - restriction-list-with-debhelper-with-conflicting-debhelper-version
       - restriction-list-with-debhelper-without-debhelper-version
       - restriction-list-with-versioned-dpkg-dev-conflict
       - restriction-list-without-versioned-dpkg-dev-dependency
       - stageX-profile-used-but-no-binary-package-dropped
 .
   * checks/{control-file,fields}.{desc,pm}:
     + [NT] Apply patch from Johannes Schauer to support the
       new build profile syntax.  (Closes: #763773)
   * checks/dbus.{desc,pm}:
     + [NT] New check by Simon McVittie to discover some dbus
       related issues.  (Closes: #762609)
   * checks/nmu.pm:
     + [JW] Avoid chopping off trailing ">" in emails in the
       canonicalize subroutine.  (Closes: #766468)
   * checks/rules.pm:
     + [JW,NT] Fix undef warning for packages with empty an
       empty d/rules file.  (Closes: #766033)
   * checks/source-copyright.pm:
     + [NT] Apply patch from Johannes Schauer to optimise the
       check.
     + [NT] Optimise for "dir/*" wildcards in DEP-5 copyright
       files.
   * checks/watch-file.pm:
     + [NT] Fix undef warning with some watch files.  Thanks
       to Axel Beckert for reporting the bug.
       (Closes: #765995)
 .
   * collection/{bin-pkg-control,unpacked}:
     + [NT] Pass "-m" to tar to make it avoid "correcting" the
       timestamp of the extracted files.  Lintian does not need
       it for correctness, so it can make tar save a few syscalls
       here.
     + [NT] Explicitly pass tar options to make it extract files
       as the current user and applying the users umask.  This is
       mostly to be explicit about how things are extracted.
   * collection/file-info:
     + [NT] Stop collecting file-info for "non-files".  The output
       is not used and often trivial / predictable from other data
       input already available.
   * collection/strings:
     + [NT] Stop creating "elf-index" file as nothing uses it.
   * collection/unpacked:
     + [NT] Gracefully handle when symlink targets contains
       newlines.  Thanks to Faheem Mitha for reporting the bug.
       (Closes: #765311)
 .
   * frontend/lintian:
     + [NT] Aggressively reset the environment a well-defined
       state at start up.  Only ENV variables starting with
       "LINTIAN_" (and a select few well known variables) are
       preserved.
     + [NT] Runtime for collections and checks now only requires
       a single --debug option.  Lintian will now also show
       runtime for other things (e.g. total runtimes).
     + [NT] Add --perf-debug and --perf-output options to enable
       logging for performance data.  This is mostly intended
       to allow collecting performance data from archive-wide
       runs.
     + [NT] Hide some options in the default output for --help.
       These can now be shown with "--help=extended".
     + [NT] Add a new "Developer/special usage options" section
       in the --help output for some options (e.g. --debug).
       This section is hidden by default.
 .
   * lib/Lintian/Relation.pm:
     + [NT] Unparsable entries are now included in relation
       objects rather than being silently discarded.
   * lib/Lintian/Util.pm:
     + [NT] Purge even more ENV variables in clean_env.
     + [NT] Add "pipe_tee" subroutine for tee'ing data from one
       input file descriptors to one or more output output file
       descriptors.
 .
   * man/lintian.pod.in:
     + [NT] Document the performance logging options.
     + [NT] Add a new "Developer/special usage options" section
       in the --help output for some options (e.g. --debug).
 .
   * private/generate-html-docs:
     + [NT] Add doctype and encoding to generated files.
 .
   * reporting/harness:
     + [NT] Add missing import.
   * reporting/html_reprots:
     + [NT] Correct the command line in the creation of the
       lintian.log.gz.
   * reporting/{html_reports,templates/*}:
     + [NT] Correct the generated HTML, which was invalid in
       some cases.
   * reporting/templates/{head,lintian.css}.tmpl:
     + [NT] Define a default "viewport".  This slightly improves
       the output on some mobile devices.
     + [NT] Add some special cases for "smaller" viewports in the
       style sheet.
   * reporting/templates/maintainer.tmpl:
     + [NT] Correct name of variable to avoid using an undefined
       variable.
 .
   * vendors/ubuntu/main/data/changes-file/known-dists:
     + [NT] Add "vivid" per request of Iain Lane.
Checksums-Sha1:
 7057229fb295cdd213c1d39a9570dad4e0c0b780 2693 lintian_2.5.29.dsc
 dd2de1aa72b612d923c7b9735c8ce1d2ac386a50 1181444 lintian_2.5.29.tar.xz
 53519af230c38aa368b0092ee45ded29899d2875 791866 lintian_2.5.29_all.deb
Checksums-Sha256:
 b946bf6a96cba7a9d2d76ba3ef143b31ce95ccb9dbf248361d091a9d515edd38 2693 lintian_2.5.29.dsc
 1525ece9ef6529ef015fe2b601a69b4cefc41168808352a40d7d477d54c5764d 1181444 lintian_2.5.29.tar.xz
 170ca7d58d71f20cf8ed5b6cd1783985dd120bb7edb6539113572d47c1934f6f 791866 lintian_2.5.29_all.deb
Files:
 c977afbfdd9cb272d21aa47422b9dd31 2693 devel optional lintian_2.5.29.dsc
 593c0be5c2c7fcd1013e19bff373d054 1181444 devel optional lintian_2.5.29.tar.xz
 0b3d164edb2cd238a61d752b0a2a6c43 791866 devel optional lintian_2.5.29_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJUSsNfAAoJEAVLu599gGRCQUwP/2r21P6yKa0KTDJSoqahVsWi
xgNbY7x1ioy1FBEMFc5vi3vmxKS1PPxtaHcTfNUQPceItdrQCDa5beLViIxtdkEg
EyU9ahBNm3NIGb+2JIHdPjPZuWoCRmXbUCV8K+skx3B2888yVfAXriRw8E61uaQB
lpUkkLasxTzQCX68yFW8S3z6HTV8BYnWLavLSWP+wic/j9n8gtKt+zfNS1t4uGmS
unI36JMieXaU5d5CWP1EGZ+aA3usKy+Lc8qWpMv6eQk1/YvlY+c4KgKLBDyDTkAw
x6WbjAvQBeeoN9D2YItAOlV/1hHF/klCMTVtqO0SJOuG1ORgH2y5waPtYUolA90H
5LtWf/vxBfh0cyUR12kRySTt3Znx8ZqK1CH9QjxJPsZTHRT9iZ2bcfXv2xUH9yAQ
hCQaZg8aTeSkM7YazF3U+9YAdFS3Ns2RkZqkYxyk0+Y6Ym5wz0U2ZErqaN/z5uQw
b4sFIl8wiVBZ2hjTx7d/GrNs5F8vhapKtUpXG75V6QgYUZ5ZZEXy2nVblw2GTrkk
MTfRbw6Uer0i3uOxCczBh3TT1AzBHNfJiwcBxgadaoCQUtyxrNoAZE3U7O+KpFSg
43+W8axiL3g9gt7YT845J9PsAxFXp/ltxZNXk8pYf6W4DuUedurZFMThbN309os3
TF4hrIw4Wg19VRy3WG6b
=kYgl
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: