[lintian] 02/02: coll/file-info: Only run file(1) on files
This is an automated email from the git hooks/post-receive script.
nthykier pushed a commit to branch master
in repository lintian.
commit e06fbe550538ca2281a66ad60c8fb210ee881580
Author: Niels Thykier <niels@thykier.net>
Date: Mon Oct 13 21:08:44 2014 +0200
coll/file-info: Only run file(1) on files
There is no reason to run file(1) on non-files, because the output is
trivial and frankly redundant. By omitting this, we save a few stat
calls in coll/file-info and slightly reduce the size of the collected
"file-info.gz".
Signed-off-by: Niels Thykier <niels@thykier.net>
---
collection/file-info | 1 +
debian/changelog | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/collection/file-info b/collection/file-info
index 5d88332..a3daf90 100755
--- a/collection/file-info
+++ b/collection/file-info
@@ -65,6 +65,7 @@ sub collect {
$opts{pipe_in}->blocking(1);
foreach my $file ($info->sorted_index) {
+ next unless $file->is_file;
printf {$opts{pipe_in}} "%s\0", $file;
}
diff --git a/debian/changelog b/debian/changelog
index 351c6ae..e58ebbd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,7 @@ lintian (2.5.29) UNRELEASED; urgency=medium
* checks/dbus.{desc,pm}:
+ [NT] New check by Simon McVittie to discover some dbus
related issues. (Closes: #762609)
+
* collection/{bin-pkg-control,unpacked}:
+ [NT] Pass "-m" to tar to make it avoid "correcting" the
timestamp of the extracted files. Lintian does not need
@@ -13,6 +14,10 @@ lintian (2.5.29) UNRELEASED; urgency=medium
+ [NT] Explicitly pass tar options to make it extract files
as the current user and applying the users umask. This is
mostly to be explicit about how things are extracted.
+ * collection/file-info:
+ + [NT] Stop collecting file-info for "non-files". The output
+ is not used and often trivial / predictable from other data
+ input already available.
* collection/strings:
+ [NT] Stop creating "elf-index" file as nothing uses it.
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: