[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 02/02: r/t/maintainers.tmpl: Avoid some invalid "</p>" tags



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 875c9c0b1a269f17d55c8691ce1aa33fe3bed422
Author: Niels Thykier <niels@thykier.net>
Date:   Thu Oct 9 21:17:01 2014 +0200

    r/t/maintainers.tmpl: Avoid some invalid "</p>" tags
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 reporting/templates/maintainers.tmpl | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/reporting/templates/maintainers.tmpl b/reporting/templates/maintainers.tmpl
index f7e5373..24ed83d 100644
--- a/reporting/templates/maintainers.tmpl
+++ b/reporting/templates/maintainers.tmpl
@@ -3,7 +3,7 @@
 
   <p>
     Maintainers are listed sorted case-insensitively by package maintainer
-    string.  This is an unsophisticated sort that doesn't take into
+    string.  This is an unsophisticated sort that does not take into
     account any national collating sequence, only Unicode strings, so
     maintainers whose names start with non-ASCII characters will sort at
     the end of this page.
@@ -11,9 +11,11 @@
 
   <p>
     Jump to: { join (' ', map { qq(<a href="#$_">$_</a>) } 'A'..'Z') }
-  </p>
-
 {
+    # !!NB!! We are deliberately leaving out the closing "</p>" here.
+    # It will be added by the loop below, which can (due to this)
+    # unconditionally emit a "</p>" at the start of each new letter.
+
     # Put headings before each new initial letter and add anchors, except
     # for non-ASCII initial characters.  For those, since we can't be
     # assured we'll get combining characters right, just accumulate them
@@ -28,9 +30,6 @@
             $first = 'Other';
         }
         if ($first ne $letter) {
-            unless ($letter) {
-                $OUT .= "  </p>\n\n";
-            }
             $letter = $first;
             if ($letter eq 'Other') {
                 $OUT .= qq(  </p>\n\n  <h2>Other</h2>\n\n  <p>\n);

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: