[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: Fix a few false positive for source missing for javascript



This is an automated email from the git hooks/post-receive script.

broucaries-guest pushed a commit to branch master
in repository lintian.

commit a3af6f0756d816f370f0f025d324afcfd6a9b95f
Author: Bastien ROUCARIÈS <roucaries.bastien+debian@gmail.com>
Date:   Sat Sep 6 17:48:50 2014 +0200

    Fix a few false positive for source missing for javascript
    
    Signed-off-by: Bastien ROUCARIÈS <roucaries.bastien+debian@gmail.com>
---
 checks/cruft.pm                                                       | 2 +-
 data/cruft/warn-file-type                                             | 2 +-
 debian/changelog                                                      | 2 ++
 .../cruft-minified-js/debian/oldfalsepositives/-debug.js/test-min.js  | 2 ++
 .../oldfalsepositives/debug.js/{test.debug.js => testdebug.debug.js}  | 0
 .../cruft-minified-js/debian/oldfalsepositives/debug.js/testdebug.js  | 4 ++++
 t/tests/cruft-minified-js/debian/oldfalsepositives/src.js/test.min.js | 3 ++-
 .../oldfalsepositives/{debug.js/test.js => suffix/test-compressed.js} | 0
 .../{-debug.js/test-min.js => suffix/test.compressed.js}              | 0
 9 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/checks/cruft.pm b/checks/cruft.pm
index 2b39599..1a526ef 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -903,7 +903,7 @@ sub _linelength_test {
             # Check for missing source.  It will check
             # for the source file in well known directories
             check_missing_source($entry,$info,$name,$basename,$dirname,
-                [['','']]);
+                [['(?i)\.js$','.debug.js'],['(?i)\.js$','-debug.js'],['','']]);
         }
     }
     return;
diff --git a/data/cruft/warn-file-type b/data/cruft/warn-file-type
index a832875..ac669b5 100644
--- a/data/cruft/warn-file-type
+++ b/data/cruft/warn-file-type
@@ -11,7 +11,7 @@ source-contains-prebuilt-flash-object       ~~ ^Macromedia \s Flash
 source-contains-prebuilt-flash-project      ~~ ^Composite \s Document \s File                                            ~~ (?i)\.fla$                        ~~ s/(?i)\.fla$/.as/
 source-contains-prebuilt-java-object        ~~ (?: Java [ ] (?:Jar [ ] file|archive [ ] data) | Zip [ ] archive | JAR)   ~~ (?i)\.jar$
 # do not forget to change also $JS_EXT in file.pm
-source-contains-prebuilt-javascript-object  ~~ .*                                                                        ~~ (?i)[-._](?:compiled|lite|min|pack(?:ed)?|yc)\.js$ ~~ map{'s/(?i)[-._](?:compiled|lite|min|pack(?:ed)?|yc)\.js$/'.$_.'/'} qw(.js _orig.js .js.orig .src.js .debug.js -debug.js)
+source-contains-prebuilt-javascript-object  ~~ .*                                                                        ~~ (?i)[-._](?:compiled|compressed|lite|min|pack(?:ed)?|yc)\.js$ ~~ map{'s/(?i)(?:[-._](?:compiled|compressed|lite|min|pack(?:ed)?|yc))?\.js$/'.$_.'/'} qw(.js _orig.js .js.orig .src.js .debug.js -debug.js)
 # ok chm could be created from docbook or texi
 source-contains-prebuilt-ms-help-file       ~~ ^MS \s Windows \s Html \s? Help \s Data ~~  (?i)\.chm$
 source-contains-prebuilt-python-object      ~~ ^python \s \d(\.\d+)? \s byte-compiled                                    ~~ .*                                ~~ s/(?i)(?:\.cpython-\d{2}|\.pypy)?\.py[co]$/.py/
diff --git a/debian/changelog b/debian/changelog
index d1e15fb..a61e2fe 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,8 @@ lintian (2.5.27) UNRELEASED; urgency=medium
 
   XXX: generate tag summary with private/generate-tag-summary
 
+  * checks/cruft.pm:
+    + [BR] Fix a few false positive is for javascript source-is-missing.
   * checks/source-copyright.pm:
     + [BR] Fix False positive for space-in-std-shortname-in-dep5-copyright
       with alternative licenses.  (Closes: #760642).
diff --git a/t/tests/cruft-minified-js/debian/oldfalsepositives/-debug.js/test-min.js b/t/tests/cruft-minified-js/debian/oldfalsepositives/-debug.js/test-min.js
index d9fd3cb..e1a0655 100644
--- a/t/tests/cruft-minified-js/debian/oldfalsepositives/-debug.js/test-min.js
+++ b/t/tests/cruft-minified-js/debian/oldfalsepositives/-debug.js/test-min.js
@@ -1,2 +1,4 @@
 // a very long javascript yuic compressed
+/* simulate a long line */
+var longline = 'XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX';
 
diff --git a/t/tests/cruft-minified-js/debian/oldfalsepositives/debug.js/test.debug.js b/t/tests/cruft-minified-js/debian/oldfalsepositives/debug.js/testdebug.debug.js
similarity index 100%
rename from t/tests/cruft-minified-js/debian/oldfalsepositives/debug.js/test.debug.js
rename to t/tests/cruft-minified-js/debian/oldfalsepositives/debug.js/testdebug.debug.js
diff --git a/t/tests/cruft-minified-js/debian/oldfalsepositives/debug.js/testdebug.js b/t/tests/cruft-minified-js/debian/oldfalsepositives/debug.js/testdebug.js
new file mode 100644
index 0000000..e1a0655
--- /dev/null
+++ b/t/tests/cruft-minified-js/debian/oldfalsepositives/debug.js/testdebug.js
@@ -0,0 +1,4 @@
+// a very long javascript yuic compressed
+/* simulate a long line */
+var longline = 'XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX';
+
diff --git a/t/tests/cruft-minified-js/debian/oldfalsepositives/src.js/test.min.js b/t/tests/cruft-minified-js/debian/oldfalsepositives/src.js/test.min.js
index d9fd3cb..d47653c 100644
--- a/t/tests/cruft-minified-js/debian/oldfalsepositives/src.js/test.min.js
+++ b/t/tests/cruft-minified-js/debian/oldfalsepositives/src.js/test.min.js
@@ -1,2 +1,3 @@
 // a very long javascript yuic compressed
-
+/* simulate a long line */
+var longline = 'XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX';
diff --git a/t/tests/cruft-minified-js/debian/oldfalsepositives/debug.js/test.js b/t/tests/cruft-minified-js/debian/oldfalsepositives/suffix/test-compressed.js
similarity index 100%
rename from t/tests/cruft-minified-js/debian/oldfalsepositives/debug.js/test.js
rename to t/tests/cruft-minified-js/debian/oldfalsepositives/suffix/test-compressed.js
diff --git a/t/tests/cruft-minified-js/debian/oldfalsepositives/-debug.js/test-min.js b/t/tests/cruft-minified-js/debian/oldfalsepositives/suffix/test.compressed.js
similarity index 100%
copy from t/tests/cruft-minified-js/debian/oldfalsepositives/-debug.js/test-min.js
copy to t/tests/cruft-minified-js/debian/oldfalsepositives/suffix/test.compressed.js

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: