[lintian] 01/01: checks: Fix some perlcritic warnings
This is an automated email from the git hooks/post-receive script.
nthykier pushed a commit to branch master
in repository lintian.
commit 1bc3e7f6287ab47e90962c4c4d4de08efda03cd4
Author: Niels Thykier <niels@thykier.net>
Date: Sat Feb 8 18:13:13 2014 +0100
checks: Fix some perlcritic warnings
The c/files.pm is a false-positive; but it was trivial to "fix" it
with little loss of readability.
Signed-off-by: Niels Thykier <niels@thykier.net>
---
checks/files.pm | 8 ++++----
checks/watch-file.pm | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/checks/files.pm b/checks/files.pm
index a4eae52..5c5a60d 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -1909,14 +1909,14 @@ sub detect_privacy_breach {
next EXTERNAL_TAG;
}
# reparse fulltag for rel
- if($tagattr eq 'link') {
+ if ($tagattr eq 'link') {
$fulltag =~ m,<\s* link
(?:\s+[^>]+)? \s+
- rel \s* = \s* "(?'relcontent'[^"\r\n]*?)"
+ rel \s* = \s* "([^"\r\n]*?)"
[^>]*?
>,xismog;
- if (defined($+{relcontent})) {
- my $relcontent = $+{relcontent};
+ my $relcontent = $1;
+ if (defined($relcontent)) {
if ($relcontent eq 'schema.dct') {
next EXTERNAL_TAG;
}
diff --git a/checks/watch-file.pm b/checks/watch-file.pm
index 9fd5a9c..59c26b3 100644
--- a/checks/watch-file.pm
+++ b/checks/watch-file.pm
@@ -182,8 +182,8 @@ sub run {
tag 'debian-watch-may-check-gpg-signature' unless ($withgpgverification);
if ($withgpgverification) {
- if ( !-f $info->debfiles('upstream-signing-key.pgp')
- and !-f $info->debfiles('upstream-signing-key.asc')) {
+ if ( !-f $info->debfiles('upstream-signing-key.pgp')
+ && !-f $info->debfiles('upstream-signing-key.asc')) {
tag 'debian-watch-file-pubkey-file-is-missing';
}
}
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: