[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: c/apache2.pm: Fix F-P when module name had uppercase letters



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit ddc0824f601900802c65bcf385185df09f7e9244
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Sep 15 23:16:36 2013 +0200

    c/apache2.pm: Fix F-P when module name had uppercase letters
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 checks/apache2.pm |    4 +++-
 debian/changelog  |    5 +++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/checks/apache2.pm b/checks/apache2.pm
index 7dd0a80..c746b36 100644
--- a/checks/apache2.pm
+++ b/checks/apache2.pm
@@ -133,7 +133,9 @@ sub check_module_package {
 
     # We want packages to be follow our naming scheme. Modules should be named
     # libapache2-mod-<foo> if it ships a mod_foo.so
-    my $expected_name = 'libapache2-' . $module;
+    # NB: Some modules have uppercase letters in them (e.g. Ruwsgi), but
+    # obviously the package should be in all lowercase.
+    my $expected_name = 'libapache2-' . lc($module);
 
     # Package depends on apache2-api-YYYYMMDD
     my $seen_api_dependency = 0;
diff --git a/debian/changelog b/debian/changelog
index 57cf039..a2a298f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,11 @@ lintian (2.5.18) UNRELEASED; urgency=low
 
   XXX: generate tag summary with private/generate-tag-summary
 
+  * checks/apache2.pm:
+    + [NT] Fix false-positive warning about non-standard package
+      name when the Apache2 module contained uppercase letters.
+      Thanks to Jonas Smedegaard for the report.
+      (Closes: #723003)
   * checks/changelog.{desc,pm}:
     + [NT] Check that the weekday of the latest changelog entry
       is consistent with the date.  Thanks to Raphael Champeimont

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: