Bug#719450: lintian: infofiles check for [image src=""] target

[Niels Thykier <niels@thykier.net>]

On 2013-08-12 00:19, Kevin Ryde wrote:
> Package: lintian
> Version: 2.5.15
> Severity: wishlist
> Tags: patch
> File: /usr/share/lintian/checks/infofiles.pm
> 
> This is an idea to notice when /usr/share/info/foo.info contains an
> image like [image src="filename.png"] but the target .png is not in the
> package.
> 
> Images can be displayed by emacs, if the png files are present.
> Current packages with this problem include bison-doc, gdb-doc, gri, and
> libforms-dev.
> 
> The .png files should exist in the source dist, since makeinfo demands a
> png for @image{} in the .texi.  So fixing a missing .png in the deb
> should be as simple as copying into the package, or mangling the src=""
> to the right place if the png is in the package but somewhere else.
> 
> [...]

Hi,

Thanks for the patches, these have been applied to the master branch.

I added a test case and also did a few tweak of the patch.  The latter
was mostly remove unused capture groups (e.g. (x) becomes (?:x)) and to
remove the leading slash in the argument to normalize_pkg_path[1].  I
figured these tweaks were too minor to bother you with fixing it. :)

~Niels

[1] Internally, Lintian refer to files relative to the package root
(i.e. without leading slash).  In the given case, normalize_pkg_path did
fix that, so it was mostly for consistency with other parts of the code.