[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Check for deprecated automake configure.in (wishlist #708482)



Hello,

I wrote a lintian check for wishlist item #708482, which simply checks
for an Automake Makefile.am and a deprecated configure.in in source
packages.

Since this is my first lintian check, I'm pretty sure it's far from
perfect, so I would be grateful if you could give me some feedback!

Best regards,

-- 
Gautier Minster 

>From 341aa5acb914ed432c7c934a3b3cd208c0a10a9f Mon Sep 17 00:00:00 2001
From: Gautier Minster <gautier+debian@minster.io>
Date: Fri, 16 Aug 2013 21:54:21 +0200
Subject: [PATCH] c/automake.pm: Added check for deprecated configure.in
 (#708482)

---
 checks/automake.desc | 13 +++++++++++++
 checks/automake.pm   | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+)
 create mode 100644 checks/automake.desc
 create mode 100644 checks/automake.pm

diff --git a/checks/automake.desc b/checks/automake.desc
new file mode 100644
index 0000000..5283358
--- /dev/null
+++ b/checks/automake.desc
@@ -0,0 +1,13 @@
+Check-Script: automake
+Author: Gautier Minster <gautier+debian@minster.io>
+Abbrev: autom
+Type: source
+Needs-Info: index
+Info: Checks for erroneous, missing or deprecated automake files
+
+Tag: deprecated-configure-filename
+Severity: pedantic
+Certainty: possible
+Info: The Autoconf input file name 'configure.in' is deprecated, use 'configure.ac'.
+Ref: https://lists.gnu.org/archive/html/automake/2013-05/msg00049.html
+Experimental: yes
diff --git a/checks/automake.pm b/checks/automake.pm
new file mode 100644
index 0000000..952ddb6
--- /dev/null
+++ b/checks/automake.pm
@@ -0,0 +1,47 @@
+# automake -- lintian check script -*- perl -*-
+#
+# Copyright (C) 2013 Gautier Minster
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, you can find it on the World Wide
+# Web at http://www.gnu.org/copyleft/gpl.html, or write to the Free
+# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+# MA 02110-1301, USA.
+
+package Lintian::automake;
+use strict;
+use warnings;
+use autodie;
+
+use Lintian::Tags qw(tag);
+
+sub run {
+    my ($pkg, $type, $info) = @_;
+
+    my $makefile = $info->index('Makefile.am');
+
+    # If there's no Makefile.am, automake probably isn't used, we're fine
+    return unless defined $makefile;
+
+    my $deprecated_configure = $info->index('configure.in');
+
+    if (defined $deprecated_configure)
+    {
+        tag 'deprecated-configure-filename';
+    }
+
+    return;
+}
+
+1;
+
-- 
1.8.4.rc2


Reply to: