[SCM] Debian package checker branch, master, updated. 2.5.11-171-g90308ca

["Niels Thykier" <niels@thykier.net>]

The following commit has been merged in the master branch:
commit c46ba0ac8f40c627cae965fca8b668175bb0b8f0
Author: Guillem Jover <guillem@debian.org>
Date:   Wed Jan 23 02:24:22 2013 +0100

    c/binaries.desc: Expands tag description to explain how to add LFS
    
    [nthykier: break the description into smaller paragraphs]
    
    Signed-off-by: Guillem Jover <guillem@debian.org>
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/binaries.desc b/checks/binaries.desc
index ffc9a36..e895ac2 100644
--- a/checks/binaries.desc
+++ b/checks/binaries.desc
@@ -364,7 +364,17 @@ Info: The listed ELF binary appears to be built without "Large File
  Support" (LFS).  If so, it may not be able to handle large files
  correctly.
  .
- To support large files, ensure that <tt>_FILE_OFFSET_BITS</tt> is
- defined and set to 64 before the relevant files are included.  This
- can be done by using the <tt>AC_SYS_LARGEFILE</tt> macro with
- autoconf.
+ To support large files, code review might be needed to make sure that
+ those files are not slurped into memory or mmap(2)ed, and that correct
+ 64-bit data types are used (ex: off_t instead of ssize_t), etc.  Once
+ that has been done ensure <tt>_FILE_OFFSET_BITS</tt> is defined and
+ set to 64 before the relevant files are included.  This can be done by
+ using the <tt>AC_SYS_LARGEFILE</tt> macro with autoconf.
+ .
+ Take into account that even if this tag is not emitted, that does not
+ mean the binary is LFS-safe (ie. no OOM conditions, file truncation
+ or overwrite will happen).
+ .
+ Also note that enabling LFS on a shared library is not always safe as
+ it might break ABI in case some of the exported types change size, in
+ those cases a SOVERSION bump might be required.

-- 
Debian package checker