[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#697395: marked as done (lintian: False positive: preinst-uses-dpkg-maintscript-helper-without-predepends)

Your message dated Tue, 08 Jan 2013 19:19:47 +0100
with message-id <50EC6343.4020207@debian.org>
and subject line Re: Bug#697395: lintian: False positive: preinst-uses-dpkg-maintscript-helper-without-predepends
has caused the Debian Bug report #697395,
regarding lintian: False positive: preinst-uses-dpkg-maintscript-helper-without-predepends
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
697395: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=697395
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.5.10.3
Severity: normal

Hello,

I have found an false positive about preinst-uses-dpkg-maintscript-helper-without-predepends.
For example fglrx-driver:

lintian complains about:
  preinst-uses-dpkg-maintscript-helper-without-predepends

withing every package. The extended description says:

	N:    The package contains a preinst maintainer script that uses
	N:    dpkg-maintscript-helper but does not declare a versoned pre-dependency
	N:    on dpkg (>= 1.15.7.2~) that provides that script.

So adding a Pre-Depends on dpkg (>= 1.15.7.2~) is enough and will work to prevent this
message, but fglrx-driver also switched to xz compression!
lintian suggests:

	N:    The deb uses xz compression for the data member, which requires a
	N:    Pre-Depends on dpkg (>= 1.15.6~). This is trivially satisfied in Debian,
	N:    but it can complicate upgrades from Ubuntu Lucid where dpkg 1.15.6 is
	N:    not currently available.

So the correct way (to prevent faults abouts preinst-uses-dpkg-maintscript-helper-without-predepends
and data.tar.xz-member-without-dpkg-pre-depends) would be to add a Pre-Depends on dpkg (>= 1.15.6~).
Done, but lintian still complains about the preinst-uses-dpkg-maintscript-helper-without-predepends
one.

You can reproduce it with svn://svn.debian.org/svn/pkg-fglrx/fglrx-driver/branches/experimental
revision 1146 for example.

-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils                       2.22-7.1
ii  bzip2                          1.0.6-4
ii  diffstat                       1.55-3
ii  file                           5.11-2
ii  gettext                        0.18.1.1-9
ii  hardening-includes             2.2
ii  intltool-debian                0.35.0+20060710.1
ii  libapt-pkg-perl                0.1.26+b1
ii  libarchive-zip-perl            1.30-6
ii  libc-bin                       2.13-37
ii  libclass-accessor-perl         0.34-1
ii  libclone-perl                  0.31-1+b2
ii  libdpkg-perl                   1.16.9
ii  libemail-valid-perl            0.190-1
ii  libipc-run-perl                0.92-1
ii  libparse-debianchangelog-perl  1.2.0-1
ii  libtimedate-perl               1.2000-1
ii  liburi-perl                    1.60-1
ii  locales                        2.13-37
ii  man-db                         2.6.2-1
ii  patchutils                     0.3.2-1.1
ii  perl [libdigest-sha-perl]      5.14.2-16

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  dpkg-dev               1.16.9
ii  libhtml-parser-perl    3.69-2
pn  libperlio-gzip-perl    <none>
pn  libtext-template-perl  <none>
ii  man-db                 2.6.2-1
ii  xz-utils [lzma]        5.1.1alpha+20120614-2

-- no debconf information

--- End Message ---
--- Begin Message --- 
Am 04.01.2013 23:05, schrieb Niels Thykier:

On 2013-01-04 21:15, Patrick Matthäi wrote:

Am 04.01.2013 21:02, schrieb Patrick Matthäi:

Package: lintian
Version: 2.5.10.3
Severity: normal

Hello,

I have found an false positive about preinst-uses-dpkg-maintscript-helper-without-predepends.
For example fglrx-driver:

lintian complains about:
   preinst-uses-dpkg-maintscript-helper-without-predepends

withing every package. The extended description says:

	N:    The package contains a preinst maintainer script that uses
	N:    dpkg-maintscript-helper but does not declare a versoned pre-dependency
	N:    on dpkg (>= 1.15.7.2~) that provides that script.

So adding a Pre-Depends on dpkg (>= 1.15.7.2~) is enough and will work to prevent this
message, but fglrx-driver also switched to xz compression!
lintian suggests:

	N:    The deb uses xz compression for the data member, which requires a
	N:    Pre-Depends on dpkg (>= 1.15.6~). This is trivially satisfied in Debian,
	N:    but it can complicate upgrades from Ubuntu Lucid where dpkg 1.15.6 is
	N:    not currently available.

So the correct way (to prevent faults abouts preinst-uses-dpkg-maintscript-helper-without-predepends
and data.tar.xz-member-without-dpkg-pre-depends) would be to add a Pre-Depends on dpkg (>= 1.15.6~).
Done, but lintian still complains about the preinst-uses-dpkg-maintscript-helper-without-predepends
one.

You can reproduce it with svn://svn.debian.org/svn/pkg-fglrx/fglrx-driver/branches/experimental
revision 1146 for example.



Ohh dear, please don't laugh, I think I am confused..
This issue appears in exactly the another way and now I also comitted shit..

fglrx-driver Pre-Depends:..
	dpkg 1.15.6~ because of the xz compression
	dpkg 1.15.7.2~ because of the maintscript helper

So on a Pre-Depends on 1.15.7.2~ is the correct one and
data.tar.xz-member-without-dpkg-pre-depends is faulty.



Hi,

I suspect I have gotten a bit confused as well now as to what the
problem is exactly.

If the package uses a data.tar.xz member it needs "dpkg (>= 1.15.6~)".
If the package uses dpkg-maintscript-helper, it would need a Pre-Depends
on "dpkg (>= 1.15.7.2~)".
   If it has both, then it needs "dpkg (>= 1.15.7.2~)", which is the
"stronger" requirement of the two.

If we can agree on paragraph above, then I am not sure I see where
Lintian made a false-positive?

~Niels
I have just failed somewhere at my tests, maybe I used the wrong directorys.. Sorry for this, closing 


--
/*
Mit freundlichem Gruß / With kind regards,
 Patrick Matthäi
 GNU/Linux Debian Developer

E-Mail: pmatthaei@debian.org
        patrick@linux-dev.org
*/

--- End Message ---
Reply to: