[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 10/15: Rename maintainer-script-modifies-netbase-managed-file to maintainer-script-should-not-modify-netbase-managed-file



This is an automated email from the git hooks/post-receive script.

broucaries-guest pushed a commit to branch master
in repository lintian.

commit 49a693a81040a74d9896619dd803944a6f408f03
Author: Bastien ROUCARIÈS <roucaries.bastien@gmail.com>
Date:   Sat Dec 14 15:13:21 2013 +0100

    Rename maintainer-script-modifies-netbase-managed-file to maintainer-script-should-not-modify-netbase-managed-file
    
    Signed-off-by: Bastien ROUCARIÈS <roucaries.bastien+debian@gmail.com>
---
 checks/scripts.desc                        | 2 +-
 data/scripts/maintainer-script-bad-command | 2 +-
 debian/changelog                           | 2 ++
 t/tests/scripts-maintainer-general/desc    | 3 +--
 t/tests/scripts-maintainer-general/tags    | 6 +++---
 5 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/checks/scripts.desc b/checks/scripts.desc
index 2995d89..6f48502 100644
--- a/checks/scripts.desc
+++ b/checks/scripts.desc
@@ -550,7 +550,7 @@ Info: The file /var/lib/dpkg/status is internal to dpkg, may disappear or
  instead.
 Ref: http://wiki.debian.org/DpkgConffileHandling
 
-Tag: maintainer-script-modifies-netbase-managed-file
+Tag: maintainer-script-should-not-modify-netbase-managed-file
 Severity: serious
 Certainty: certain
 Info: The maintainer script modifies at least one of the files
diff --git a/data/scripts/maintainer-script-bad-command b/data/scripts/maintainer-script-bad-command
index 623355c..c723c28 100644
--- a/data/scripts/maintainer-script-bad-command
+++ b/data/scripts/maintainer-script-bad-command
@@ -21,7 +21,6 @@
 #
 # ftpmaster auto reject so do not rename
 install-info-used-in-maintainer-script                          ~~ 1 ~~                    ~~          ~~\binstall-info\b
-maintainer-script-modifies-netbase-managed-file                 ~~ 0 ~~                    ~~          ~~(?:\A\s*(?:cp|mv)\s+.*\s+|>\s*)(/etc/(?:services|protocols|rpc))\s*(?:\s|\Z)
 maintainer-script-removes-device-files                          ~~ 0 ~~                    ~~          ~~^\s*rm\s+(?:[^>]*\s)?(/dev/(?!(?:shm/|\.[^.]+))[^/ ]+)
 maintainer-script-uses-dpkg-status-directly                     ~~ 1 ~~^(base-files|dpkg)$ ~~          ~~/var/lib/dpkg/status\b
 maintainer-script-should-not-hide-init-failure                  ~~ 0 ~~                    ~~          ~~invoke-rc.d.*\|\| \s+ exit \s+ 0
@@ -33,6 +32,7 @@ maintainer-script-should-not-use-fc-cache                       ~~ 0 ~~^(fontcon
 maintainer-script-should-not-use-gconftool                      ~~ 1 ~~^(gconf\d)$         ~~          ~~(?:/usr/bin/)?gconftool(?:-\d)?(?:\s|\Z)
 maintainer-script-should-not-use-install-sgmlcatalog            ~~ 1 ~~                    ~~          ~~\binstall-sgmlcatalog\b
 maintainer-script-should-not-modify-ld-so-conf                  ~~ 0 ~~^libc               ~~          ~~(?:\A\s*(?:cp|mv)\s+.*\s+|>\s*)/etc/ld\.so\.conf\s*(?:\s|\Z)
+maintainer-script-should-not-modify-netbase-managed-file        ~~ 0 ~~                    ~~          ~~(?:\A\s*(?:cp|mv)\s+.*\s+|>\s*)(/etc/(?:services|protocols|rpc))\s*(?:\s|\Z)
 update-alternatives-remove-called-in-postrm                     ~~ 1 ~~                    ~~^postrm$  ~~\b update\-alternatives\s+\-\-remove\b
 update-alternatives-set-called-in-maintainer-script             ~~ 1 ~~                    ~~          ~~\b update\-alternatives\s+\-\-(?:set|set\-selections|config)\b
 start-stop-daemon-in-maintainer-script                          ~~ 0 ~~                    ~~          ~~\s*start-stop-daemon(?=\s)(?!.*\s--stop\b)
diff --git a/debian/changelog b/debian/changelog
index 43a1feb..a5c5311 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -52,6 +52,8 @@ lintian (2.5.20) UNRELEASED; urgency=low
       maintainer-script-should-not-hide-init-failure.
     + [BR] Rename maintainer-script-modifies-ld-so-conf to
       maintainer-script-should-not-modify-ld-so-conf
+    + [BR] Rename maintainer-script-modifies-netbase-managed-file to
+      maintainer-script-should-not-modify-netbase-managed-file
   * checks/standards-version:
     + [BR] Use Lintian::Data for ancient date check.
   * checks/watch.{desc,pm}:
diff --git a/t/tests/scripts-maintainer-general/desc b/t/tests/scripts-maintainer-general/desc
index df54980..a355399 100644
--- a/t/tests/scripts-maintainer-general/desc
+++ b/t/tests/scripts-maintainer-general/desc
@@ -11,8 +11,6 @@ Test-For:
  maintainer-script-has-unexpanded-debhelper-token
  maintainer-script-ignores-errors
  maintainer-script-modifies-inetd-conf
- maintainer-script-modifies-ld-so-conf
- maintainer-script-modifies-netbase-managed-file
  maintainer-script-needs-depends-on-adduser
  maintainer-script-needs-depends-on-gconf2
  maintainer-script-needs-depends-on-ucf
@@ -27,6 +25,7 @@ Test-For:
  maintainer-script-should-not-use-gconftool
  maintainer-script-should-not-use-install-sgmlcatalog
  maintainer-script-should-not-modify-ld-so-conf
+ maintainer-script-should-not-modify-netbase-managed-file
  mknod-in-maintainer-script
  possibly-insecure-handling-of-tmp-files-in-maintainer-script
  read-in-maintainer-script
diff --git a/t/tests/scripts-maintainer-general/tags b/t/tests/scripts-maintainer-general/tags
index a14b4e1..f446057 100644
--- a/t/tests/scripts-maintainer-general/tags
+++ b/t/tests/scripts-maintainer-general/tags
@@ -1,11 +1,11 @@
 E: scripts-maintainer-general: maintainer-script-modifies-inetd-conf postinst:67
 E: scripts-maintainer-general: maintainer-script-modifies-inetd-conf postinst:68
-E: scripts-maintainer-general: maintainer-script-modifies-netbase-managed-file postinst:59 '/etc/services'
-E: scripts-maintainer-general: maintainer-script-modifies-netbase-managed-file postinst:60 '/etc/protocols'
-E: scripts-maintainer-general: maintainer-script-modifies-netbase-managed-file postinst:61 '/etc/rpc'
 E: scripts-maintainer-general: maintainer-script-removes-device-files postinst:141 '/dev/null'
 E: scripts-maintainer-general: maintainer-script-should-not-modify-ld-so-conf postinst:108
 E: scripts-maintainer-general: maintainer-script-should-not-modify-ld-so-conf postinst:110
+E: scripts-maintainer-general: maintainer-script-should-not-modify-netbase-managed-file postinst:59 '/etc/services'
+E: scripts-maintainer-general: maintainer-script-should-not-modify-netbase-managed-file postinst:60 '/etc/protocols'
+E: scripts-maintainer-general: maintainer-script-should-not-modify-netbase-managed-file postinst:61 '/etc/rpc'
 E: scripts-maintainer-general: maintainer-script-should-not-use-adduser-system-without-home postinst:148
 E: scripts-maintainer-general: maintainer-script-should-not-use-adduser-system-without-home postinst:149
 E: scripts-maintainer-general: maintainer-script-should-not-use-install-sgmlcatalog postinst:74

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: